Skip to content

ggupset breaks with version 3.3.0 #3914

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
const-ae opened this issue Mar 29, 2020 · 2 comments
Closed

ggupset breaks with version 3.3.0 #3914

const-ae opened this issue Mar 29, 2020 · 2 comments

Comments

@const-ae
Copy link

Hi,

I noticed yesterday that with the new version of ggplot, my extension ggupset breaks when I add a scale_x_mergelist().
On the positive side, the main functionality of the package is still intact and my replacement combination matrix axis still works.

However, I have a helper function scale_x_mergelist() that converts a list column into a character vector with paste(..., collapse = "-"). Previously, the collapsed string was shown on the x-axis, now it is blank:

library(ggplot2)
library(ggupset)
ggplot(tidy_movies, aes(x = Genres)) +
  geom_bar() +
  scale_x_mergelist(sep = "-")

Created on 2020-03-29 by the reprex package (v0.3.0)

Before the change the plot looked like this:

From my preliminary investigations, I think the issue might be related to #3398. However, I cannot figure out how to adapt the code of my package to make it work again.

@clauswilke
Copy link
Member

I assume this will help: haleyjeppson/ggmosaic#41 (comment)
See also: haleyjeppson/ggmosaic#42
(Though I would probably just bump the version requirement for ggplot2 and not bother with fixing things for older version of ggplot2.)

@const-ae
Copy link
Author

Thank you for the quick reply. Adding guide = ggplot2::waiver() fixed the issue :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants