Do not pass stringsAsFactors to data_frame() (#4078)

Author: yutannihilation

tests/testthat/test-build.r

@@ -48,7 +48,7 @@ test_that("non-position aesthetics are mapped", {
 })
 
 test_that("strings are not converted to factors", {
-  df <- data_frame(x = 1:2, y = 2:1, label = c("alpha", "beta"), stringsAsFactors = FALSE)
+  df <- data_frame(x = 1:2, y = 2:1, label = c("alpha", "beta"))
   p <- ggplot(df, aes(x, y)) +
     geom_text(aes(label = label), parse = TRUE)
 

tests/testthat/test-data.r

@@ -4,8 +4,8 @@ test_that("stringsAsFactors doesn't affect results", {
     old <- getOption("stringsAsFactors")
     on.exit(options(stringsAsFactors = old), add = TRUE)
 
-    dat.character <- data_frame(x = letters[5:1], y = 1:5, stringsAsFactors = FALSE)
-    dat.factor <- data_frame(x = letters[5:1], y = 1:5, stringsAsFactors = TRUE)
+    dat.character <- data_frame(x = letters[5:1], y = 1:5)
+    dat.factor <- data_frame(x = letters[5:1], y = 1:5)
 
     base <- ggplot(mapping = aes(x, y)) + geom_point()
     xlabels <- function(x) x$layout$panel_params[[1]]$x$get_labels()

tests/testthat/test-position-dodge2.R

@@ -40,8 +40,7 @@ test_that("rectangles are dodged", {
 test_that("cols at the same x position are dodged", {
   df <- data_frame(
     x = c("a", "a", "b"),
-    n = c(1, 5, 10),
-    stringsAsFactors = FALSE
+    n = c(1, 5, 10)
   )
 
   p <- ggplot(df, aes(1, n, fill = x)) +