Skip to content

Commit 72dcfad

Browse files
authored
Omit rownames from check (#5435)
1 parent 69e7430 commit 72dcfad

File tree

2 files changed

+9
-1
lines changed

2 files changed

+9
-1
lines changed

R/aes.R

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -436,7 +436,7 @@ extract_target_is_likely_data <- function(x, data, env) {
436436

437437
tryCatch({
438438
data_eval <- eval_tidy(x[[2]], data, env)
439-
identical(data_eval, data)
439+
identical(unrowname(data_eval), unrowname(data))
440440
}, error = function(err) FALSE)
441441
}
442442

tests/testthat/test-aes.R

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -128,6 +128,14 @@ test_that("warn_for_aes_extract_usage() warns for discouraged uses of $ and [[ w
128128
warn_for_aes_extract_usage(aes(df[["x"]]), df),
129129
'Use of `df\\[\\["x"\\]\\]` is discouraged'
130130
)
131+
132+
# Check that rownames are ignored (#5392)
133+
df2 <- df
134+
rownames(df2) <- LETTERS[seq_len(nrow(df))]
135+
expect_warning(
136+
warn_for_aes_extract_usage(aes(df$x), df2),
137+
"Use of `df\\$x` is discouraged"
138+
)
131139
})
132140

133141
test_that("warn_for_aes_extract_usage() does not evaluate function calls", {

0 commit comments

Comments
 (0)