Skip to content

Commit 1f3fc2e

Browse files
authored
Bump level of panel grid blanknness in theme_classic() (#6321)
* use grid parent element to invoke blank element * Tweak bullet with related changes
1 parent ef9d417 commit 1f3fc2e

File tree

2 files changed

+7
-5
lines changed

2 files changed

+7
-5
lines changed

NEWS.md

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -278,8 +278,11 @@
278278
is setup once in total instead of once per group (@teunbrand, #5971)
279279
* `facet_grid(space = "free")` can now be combined with `coord_fixed()`
280280
(@teunbrand, #4584).
281-
* `theme_classic()` now has black ticks and text instead of dark gray. In
282-
addition, `theme_classic()`'s axis line end is `"square"` (@teunbrand, #5978).
281+
* `theme_classic()` has the following changes (@teunbrand, #5978 & #6320):
282+
* Axis ticks are now black (`ink`-coloured) instead of dark gray.
283+
* Axis line ends are now `"square"`.
284+
* The panel grid is now blank at the `panel.grid` hierarchy level instead of
285+
the `panel.grid.major` and `panel.grid.minor` levels.
283286
* {tibble} is now suggested instead of imported (@teunbrand, #5986)
284287
* The ellipsis argument is now checked in `fortify()`, `get_alt_text()`,
285288
`labs()` and several guides (@teunbrand, #3196).

R/theme-defaults.R

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -495,9 +495,8 @@ theme_classic <- function(base_size = 11, base_family = "",
495495
) %+replace%
496496
theme(
497497
# no background and no grid
498-
panel.border = element_blank(),
499-
panel.grid.major = element_blank(),
500-
panel.grid.minor = element_blank(),
498+
panel.border = element_blank(),
499+
panel.grid = element_blank(),
501500

502501
# show axes
503502
axis.text = element_text(size = rel(0.8)),

0 commit comments

Comments
 (0)