Skip to content

Commit 10fb7ac

Browse files
authored
📝 Update contributing guidelines to review translation PRs (#1215)
1 parent a1a19b1 commit 10fb7ac

File tree

1 file changed

+15
-1
lines changed

1 file changed

+15
-1
lines changed

docs/en/docs/contributing.md

Lines changed: 15 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -257,7 +257,16 @@ Here are the steps to help with translations.
257257

258258
#### Tips and guidelines
259259

260-
* Add a single Pull Request per page translated. That will make it much easier for others to review it.
260+
* Check the currently <a href="https://github.com/tiangolo/fastapi/pulls" class="external-link" target="_blank">existing pull requests</a> for your language and add reviews requesting changes or approving them.
261+
262+
!!! tip
263+
You can <a href="https://help.github.com/en/github/collaborating-with-issues-and-pull-requests/commenting-on-a-pull-request" class="external-link" target="_blank">add comments with change suggestions</a> to existing pull requests.
264+
265+
Check the docs about <a href="https://help.github.com/en/github/collaborating-with-issues-and-pull-requests/about-pull-request-reviews" class="external-link" target="_blank">adding a pull request review</a> to approve it or request changes.
266+
267+
* Check in the <a href="https://github.com/tiangolo/fastapi/issues" class="external-link" target="_blank">issues</a> to see if there's one coordinating translations for your language.
268+
269+
* Add a single pull request per page translated. That will make it much easier for others to review it.
261270

262271
For the languages I don't speak, I'll wait for several others to review the translation before merging.
263272

@@ -385,6 +394,11 @@ Updating en
385394

386395
Now you can check in your code editor the newly created directory `docs/ht/`.
387396

397+
!!! tip
398+
Create a first pull request with just this, to set up the configuration for the new language, before adding translations.
399+
400+
That way others can help with other pages while you work on the first one. 🚀
401+
388402
Start by translating the main page, `docs/ht/index.md`.
389403

390404
Then you can continue with the previous instructions, for an "Existing Language".

0 commit comments

Comments
 (0)