Skip to content

Commit c859b4d

Browse files
committed
overwrite tests for sparse array
1 parent 0a9fe11 commit c859b4d

File tree

2 files changed

+24
-10
lines changed

2 files changed

+24
-10
lines changed

pandas/tests/extension/base/methods.py

+4-10
Original file line numberDiff line numberDiff line change
@@ -111,25 +111,19 @@ def test_fillna_copy_frame(self, data_missing):
111111

112112
filled_val = df.iloc[0, 0]
113113
result = df.fillna(filled_val)
114-
assert df.values.base is not result.values.base
115114

116-
if isinstance(arr, pd.SparseArray):
117-
assert df.A._values.to_dense() is arr.to_dense()
118-
else:
119-
assert df.A._values is arr
115+
assert df.values.base is not result.values.base
116+
assert df.A._values is arr
120117

121118
def test_fillna_copy_series(self, data_missing):
122119
arr = data_missing.take([1, 1])
123120
ser = pd.Series(arr)
124121

125122
filled_val = ser[0]
126123
result = ser.fillna(filled_val)
127-
assert ser._values is not result._values
128124

129-
if isinstance(arr, pd.SparseArray):
130-
assert ser._values.to_dense() is arr.to_dense()
131-
else:
132-
assert ser._values is arr
125+
assert ser._values is not result._values
126+
assert ser._values is arr
133127

134128
def test_fillna_length_mismatch(self, data_missing):
135129
with (tm.assert_raises_regex(ValueError,

pandas/tests/extension/test_sparse.py

+20
Original file line numberDiff line numberDiff line change
@@ -231,6 +231,26 @@ def test_combine_le(self, data_repeated):
231231
], fill_value=False))
232232
self.assert_series_equal(result, expected)
233233

234+
def test_fillna_copy_frame(self, data_missing):
235+
arr = data_missing.take([1, 1])
236+
df = pd.DataFrame({"A": arr})
237+
238+
filled_val = df.iloc[0, 0]
239+
result = df.fillna(filled_val)
240+
241+
assert df.values.base is not result.values.base
242+
assert df.A._values.to_dense() is arr.to_dense()
243+
244+
def test_fillna_copy_series(self, data_missing):
245+
arr = data_missing.take([1, 1])
246+
ser = pd.Series(arr)
247+
248+
filled_val = ser[0]
249+
result = ser.fillna(filled_val)
250+
251+
assert ser._values is not result._values
252+
assert ser._values.to_dense() is arr.to_dense()
253+
234254
@pytest.mark.skip(reason="Not Applicable")
235255
def test_fillna_length_mismatch(self, data_missing):
236256
pass

0 commit comments

Comments
 (0)