remove data_for_fillna and add series tests

Author: thoo

pandas/tests/extension/base/methods.py

@@ -105,13 +105,32 @@ def test_factorize_equivalence(self, data_for_grouping, na_sentinel):
         tm.assert_numpy_array_equal(l1, l2)
         self.assert_extension_array_equal(u1, u2)
 
-    def test_fillna_copy(self, data_for_fillna):
-        df = pd.DataFrame({"A": data_for_fillna})
+    def test_fillna_copy_frame(self, data):
+        arr = data.take([1, 1])
+        df = pd.DataFrame({"A": arr})
         filled_val = df.iloc[0, 0]
 
         result = df.fillna(filled_val)
         assert df.values.base is not result.values.base
 
+        if isinstance(arr, pd.SparseArray):
+            assert df.A._values.to_dense() is arr.to_dense()
+        else:
+            assert df.A._values is arr
+
+    def test_fillna_copy_series(self, data):
+        arr = data.take([1, 1])
+        ser = pd.Series(arr)
+        filled_val = ser[0]
+
+        result = ser.fillna(filled_val)
+        assert ser._values is not result._values
+
+        if isinstance(arr, pd.SparseArray):
+            assert ser._values.to_dense() is arr.to_dense()
+        else:
+            assert ser._values is arr
+
     def test_combine_le(self, data_repeated):
         # GH 20825
         # Test that combine works when doing a <= (le) comparison

pandas/tests/extension/decimal/test_decimal.py

@@ -27,11 +27,6 @@ def data_missing():
     return DecimalArray([decimal.Decimal('NaN'), decimal.Decimal(1)])
 
 
-@pytest.fixture
-def data_for_fillna():
-    return DecimalArray([decimal.Decimal(1), decimal.Decimal(1)])
-
-
 @pytest.fixture
 def data_for_sorting():
     return DecimalArray([decimal.Decimal('1'),

pandas/tests/extension/json/test_json.py

@@ -41,12 +41,6 @@ def data_missing():
     return JSONArray([{}, {'a': 10}])
 
 
-@pytest.fixture
-def data_for_fillna():
-    """Length 2 array with [Valid, Valid]"""
-    return JSONArray([{'a': 1}, {'a': 2}])
-
-
 @pytest.fixture
 def data_for_sorting():
     return JSONArray([{'b': 1}, {'c': 4}, {'a': 2, 'c': 3}])

pandas/tests/extension/test_categorical.py

@@ -46,12 +46,6 @@ def data_missing():
     return Categorical([np.nan, 'A'])
 
 
-@pytest.fixture
-def data_for_fillna():
-    """Length 2 array with [Valid, Valid]"""
-    return Categorical(['A', 'A'])
-
-
 @pytest.fixture
 def data_for_sorting():
     return Categorical(['A', 'B', 'C'], categories=['C', 'A', 'B'],

pandas/tests/extension/test_integer.py

@@ -47,11 +47,6 @@ def data_missing(dtype):
     return integer_array([np.nan, 1], dtype=dtype)
 
 
-@pytest.fixture
-def data_for_fillna(dtype):
-    return integer_array([1, 1], dtype=dtype)
-
-
 @pytest.fixture
 def data_for_sorting(dtype):
     return integer_array([1, 2, 0], dtype=dtype)

pandas/tests/extension/test_interval.py

@@ -47,12 +47,6 @@ def data_missing():
     return IntervalArray.from_tuples([None, (0, 1)])
 
 
-@pytest.fixture
-def data_for_fillna():
-    """Length 2 array with [Valid, Valid]"""
-    return IntervalArray.from_tuples([(1, 1), (1, 2)])
-
-
 @pytest.fixture
 def data_for_sorting():
     return IntervalArray.from_tuples([(1, 2), (2, 3), (0, 1)])

pandas/tests/extension/test_sparse.py

@@ -37,12 +37,6 @@ def data_missing(request):
     return SparseArray([np.nan, 1], fill_value=request.param)
 
 
-@pytest.fixture(params=[0, np.nan])
-def data_for_fillna(request):
-    """Length 2 array with [Valid, Valid]"""
-    return SparseArray([1, 1], fill_value=request.param)
-
-
 @pytest.fixture(params=[0, np.nan])
 def data_repeated(request):
     """Return different versions of data for count times"""