Skip to content

Commit e1e3f32

Browse files
admvxcode-asher
authored andcommitted
Add missing PWA icon (coder#1060)
- Copy old icon back into repository - Update path to icon from manifest file - Add link metadata tag for iOS PWA icon to workbench.html - Add link metadata tag for iOS PWA icon to login page
1 parent 4290cff commit e1e3f32

File tree

4 files changed

+6
-4
lines changed

4 files changed

+6
-4
lines changed

scripts/vscode.patch

+3-2
Original file line numberDiff line numberDiff line change
@@ -146,10 +146,10 @@ index 3ae24454cb..d637d02855 100644
146146
// Do nothing. If we can't read the file we have no
147147
// language pack config.
148148
diff --git a/src/vs/code/browser/workbench/workbench.html b/src/vs/code/browser/workbench/workbench.html
149-
index 44f67f0a0b..00fc1deea8 100644
149+
index 44f67f0a0b..50d29b1e87 100644
150150
--- a/src/vs/code/browser/workbench/workbench.html
151151
+++ b/src/vs/code/browser/workbench/workbench.html
152-
@@ -18,10 +18,11 @@
152+
@@ -18,10 +18,12 @@
153153

154154
<!-- Workarounds/Hacks (remote user data uri) -->
155155
<meta id="vscode-remote-user-data-uri" data-settings="{{REMOTE_USER_DATA_URI}}">
@@ -160,6 +160,7 @@ index 44f67f0a0b..00fc1deea8 100644
160160
- <link rel="manifest" href="/manifest.json">
161161
+ <link rel="icon" href="./favicon.ico" type="image/x-icon" />
162162
+ <link rel="manifest" href="./manifest.json">
163+
+ <link rel="apple-touch-icon" href="./static/out/vs/server/src/media/code-server.png" />
163164
<link data-name="vs/workbench/workbench.web.api" rel="stylesheet" href="./static/out/vs/workbench/workbench.web.api.css">
164165
</head>
165166

src/login/index.html

+1
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,7 @@
66
<title>Authenticate: code-server</title>
77
<link rel="icon" href="./favicon.ico" type="image/x-icon" />
88
<link rel="manifest" href="./manifest.json">
9+
<link rel="apple-touch-icon" href="./static/out/vs/server/src/media/code-server.png" />
910
<link href="./static/out/vs/server/src/media/login.css" rel="stylesheet">
1011
</head>
1112
<body>

src/media/code-server.png

38.7 KB
Loading

src/media/manifest.json

+2-2
Original file line numberDiff line numberDiff line change
@@ -6,8 +6,8 @@
66
"background-color": "#fff",
77
"description": "Run VS Code on a remote server.",
88
"icons": [{
9-
"src": "static/code-server.png",
10-
"sizes": "128x128",
9+
"src": "./static/out/vs/server/src/media/code-server.png",
10+
"sizes": "384x384",
1111
"type": "image/png"
1212
}]
1313
}

0 commit comments

Comments
 (0)