refactor(no-node-access): narrow error cases

Author: thebinaryfelix

lib/rules/no-node-access.ts

@@ -23,19 +23,19 @@ export default ESLintUtils.RuleCreator(getDocsUrl)({
   defaultOptions: [],
 
   create(context) {
-    function showErrorForNodeAccess(node: TSESTree.Identifier) {
-      isIdentifier(node) &&
-        ALL_RETURNING_NODES.includes(node.name) &&
+    function showErrorForNodeAccess(node: TSESTree.MemberExpression) {
+      isIdentifier(node.property) &&
+        ALL_RETURNING_NODES.includes(node.property.name) &&
         context.report({
           node: node,
-          loc: node.loc.start,
+          loc: node.property.loc.start,
           messageId: 'noNodeAccess',
         });
     }
 
     return {
-      ['ExpressionStatement MemberExpression Identifier']: showErrorForNodeAccess,
-      ['VariableDeclarator Identifier']: showErrorForNodeAccess,
+      ['ExpressionStatement MemberExpression']: showErrorForNodeAccess,
+      ['VariableDeclarator MemberExpression']: showErrorForNodeAccess,
     };
   },
 });

tests/lib/rules/no-node-access.test.ts

@@ -14,6 +14,19 @@ ruleTester.run(RULE_NAME, rule, {
         const buttonText = screen.getByText('submit');
       `,
     },
+    {
+      code: `
+        const { getByText } = screen
+        const firstChild = getByText('submit');
+        expect(firstChild).toBeInTheDocument()
+      `,
+    },
+    {
+      code: `
+        const firstChild = screen.getByText('submit');
+        expect(firstChild).toBeInTheDocument()
+      `,
+    },
     {
       code: `
         const { getByText } = screen;