forked from testing-library/eslint-plugin-testing-library
-
Notifications
You must be signed in to change notification settings - Fork 0
/
Copy pathno-container.ts
103 lines (96 loc) · 2.96 KB
/
no-container.ts
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
import { ESLintUtils, TSESTree } from '@typescript-eslint/experimental-utils';
import { getDocsUrl } from '../utils';
import {
isIdentifier,
isMemberExpression,
isObjectPattern,
isProperty,
isRenderVariableDeclarator,
} from '../node-utils';
export const RULE_NAME = 'no-container';
export default ESLintUtils.RuleCreator(getDocsUrl)({
name: RULE_NAME,
meta: {
type: 'problem',
docs: {
description: 'Disallow the use of container methods',
category: 'Best Practices',
recommended: 'error',
},
messages: {
noContainer:
'Avoid using container to query for elements. Prefer using query methods from Testing Library, such as "getByRole()"',
},
fixable: null,
schema: [
{
type: 'object',
properties: {
renderFunctions: {
type: 'array',
},
},
},
],
},
defaultOptions: [
{
renderFunctions: [],
},
],
create(context, [options]) {
const { renderFunctions } = options;
let containerName = '';
let renderWrapperName = '';
let hasPropertyContainer = false;
return {
VariableDeclarator(node) {
if (isRenderVariableDeclarator(node, renderFunctions)) {
if (isObjectPattern(node.id)) {
const containerIndex = node.id.properties.findIndex(
property =>
isProperty(property) &&
isIdentifier(property.key) &&
property.key.name === 'container'
);
const nodeValue =
containerIndex !== -1 && node.id.properties[containerIndex].value;
containerName = isIdentifier(nodeValue) && nodeValue.name;
} else {
renderWrapperName = isIdentifier(node.id) && node.id.name;
}
}
},
CallExpression(node: TSESTree.CallExpression) {
function showErrorForChainedContainerMethod(
innerNode: TSESTree.MemberExpression
) {
if (isMemberExpression(innerNode)) {
if (isIdentifier(innerNode.object)) {
const isScreen = innerNode.object.name === 'screen';
const isContainerName = innerNode.object.name === containerName;
const isRenderWrapper =
innerNode.object.name === renderWrapperName;
hasPropertyContainer =
isIdentifier(innerNode.property) &&
innerNode.property.name === 'container' &&
(isScreen || isRenderWrapper);
if (isContainerName || hasPropertyContainer) {
context.report({
node,
messageId: 'noContainer',
});
}
}
showErrorForChainedContainerMethod(
innerNode.object as TSESTree.MemberExpression
);
}
}
if (isMemberExpression(node.callee)) {
showErrorForChainedContainerMethod(node.callee);
}
},
};
},
});