Skip to content

Commit c7e289b

Browse files
committed
Update signing configuration
1 parent afc97a1 commit c7e289b

File tree

5 files changed

+37
-20
lines changed

5 files changed

+37
-20
lines changed

.github/workflows/publish-maven-central.yml

+10-9
Original file line numberDiff line numberDiff line change
@@ -26,18 +26,19 @@ jobs:
2626
- name: Gradle wrapper validation
2727
uses: gradle/[email protected]
2828

29-
# Runs a single command using the runners shell
30-
- name: Install gpg secret key
31-
run: |
32-
cat <(echo -e "${{ secrets.GPG_PRIVATE_KEY }}") | gpg --batch --import
33-
gpg --export-secret-keys >$HOME/.gnupg/secring.gpg
34-
gpg --list-secret-keys --keyid-format LONG
35-
ls -l $HOME/.gnupg
36-
3729
# FIXME Check https://github.com/allure-framework/allure2/blob/430255d8cf5c236ed29bc0df0b72dcd9389c3df9/.github/workflows/release.yaml
3830
- name: Publish Release Candidate
31+
env:
32+
ORG_GRADLE_PROJECT_ghGitSourceUsername: ${{ github.actor }}
33+
ORG_GRADLE_PROJECT_ghGitSourcePassword: ${{ secrets.GITHUB_TOKEN }}
34+
ORG_GRADLE_PROJECT_ghNexusUsername: ${{ secrets.NEXUS_USERNAME }}
35+
ORG_GRADLE_PROJECT_ghNexusPassword: ${{ secrets.NEXUS_PASSWORD }}
36+
ORG_GRADLE_PROJECT_signingKeyId: ${{ secrets.GPG_KEY_ID }}
37+
ORG_GRADLE_PROJECT_signingKey: ${{ secrets.GPG_PRIVATE_KEY }}
38+
ORG_GRADLE_PROJECT_signingPassword: ${{ secrets.GPG_PASSPHRASE }}
39+
ORG_GRADLE_PROJECT_rc: ${{ github.event.inputs.release_candidate }}
3940
run: |
40-
./gradlew -PghGitSourceUsername=cbeust -PghGitSourcePassword=${{ secrets.GITHUB_TOKEN }} -PghDryRun -PghNexusUsername=${{ secrets.NEXUS_USERNAME }} -PghNexusPassword=${{ secrets.NEXUS_PASSWORD }} -Psigning.secretKeyRingFile=$HOME/.gnupg/secring.gpg -Psigning.password=${{ secrets.GPG_PASSPHRASE }} -Psigning.keyId=${{ secrets.GPG_KEY_ID }} -Prc=${{ github.event.inputs.release_candidate }} prepareVote
41+
./gradlew -PghDryRun prepareVote
4142
4243
- name: Display next step
4344
run: |

.github/workflows/release-maven-central.yml

+10-9
Original file line numberDiff line numberDiff line change
@@ -31,20 +31,21 @@ jobs:
3131
- name: Gradle wrapper validation
3232
uses: gradle/[email protected]
3333

34-
# Runs a single command using the runners shell
35-
- name: Install gpg secret key
36-
run: |
37-
cat <(echo -e "${{ secrets.GPG_PRIVATE_KEY }}") | gpg --batch --import
38-
gpg --export-secret-keys >$HOME/.gnupg/secring.gpg
39-
gpg --list-secret-keys --keyid-format LONG
40-
ls -l $HOME/.gnupg
41-
4234
- name: Create Nexus.txt with staging repository details
4335
run: |
4436
mkdir -p build/stagingRepositories
4537
echo -n ${{ github.event.inputs.staging_repository_id }} > build/stagingRepositories/nexus.txt
4638
4739
# FIXME Check https://github.com/allure-framework/allure2/blob/430255d8cf5c236ed29bc0df0b72dcd9389c3df9/.github/workflows/release.yaml
4840
- name: Publish Release Candidate
41+
env:
42+
ORG_GRADLE_PROJECT_ghGitSourceUsername: ${{ github.actor }}
43+
ORG_GRADLE_PROJECT_ghGitSourcePassword: ${{ secrets.GITHUB_TOKEN }}
44+
ORG_GRADLE_PROJECT_ghNexusUsername: ${{ secrets.NEXUS_USERNAME }}
45+
ORG_GRADLE_PROJECT_ghNexusPassword: ${{ secrets.NEXUS_PASSWORD }}
46+
ORG_GRADLE_PROJECT_signingKeyId: ${{ secrets.GPG_KEY_ID }}
47+
ORG_GRADLE_PROJECT_signingKey: ${{ secrets.GPG_PRIVATE_KEY }}
48+
ORG_GRADLE_PROJECT_signingPassword: ${{ secrets.GPG_PASSPHRASE }}
49+
ORG_GRADLE_PROJECT_rc: ${{ github.event.inputs.release_candidate }}
4950
run: |
50-
./gradlew -PghGitSourceUsername=cbeust -PghGitSourcePassword=${{ secrets.GITHUB_TOKEN }} -PghDryRun -PghNexusUsername=${{ secrets.NEXUS_USERNAME }} -PghNexusPassword=${{ secrets.NEXUS_PASSWORD }} -Psigning.secretKeyRingFile=$HOME/.gnupg/secring.gpg -Psigning.password=${{ secrets.GPG_PASSPHRASE }} -Psigning.keyId=${{ secrets.GPG_KEY_ID }} -Prc=${{ github.event.inputs.release_candidate }} publishDist
51+
./gradlew -PghDryRun publishDist

build-logic/publishing/src/main/kotlin/testng.maven-publish.gradle.kts

+1
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,7 @@
11
plugins {
22
`maven-publish`
33
id("testng.local-maven-repo")
4+
id("testng.signing")
45
}
56

67
// It takes value from root project always: https://github.com/gradle/gradle/issues/13302
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,14 @@
1+
import org.gradle.kotlin.dsl.signing
2+
3+
plugins {
4+
signing
5+
}
6+
7+
plugins.withId("signing") {
8+
configure<SigningExtension> {
9+
val signingKeyId: String? by project
10+
val signingKey: String? by project
11+
val signingPassword: String? by project
12+
useInMemoryPgpKeys(signingKeyId, signingKey, signingPassword)
13+
}
14+
}

gradle.properties

+2-2
Original file line numberDiff line numberDiff line change
@@ -15,9 +15,9 @@ project.vendor.name=TestNG
1515
project.vendor.id=org.testng
1616

1717
# For now this URL is used only in POM references, and release tags are pused
18-
scm.url=https\://github.com/cbeust/testng.git
18+
scm.url=https\://github.com/testng-team/testng.git
1919

2020
# In most cases it is the same as the project group
2121
nexus.profile=org.testng
22-
github.organization=cbeust
22+
github.organization=testng-team
2323
github.repository=testng

0 commit comments

Comments
 (0)