From 40ec8371b97630afd2989b2d60c3b9b5b065eef7 Mon Sep 17 00:00:00 2001 From: Nick McCurdy Date: Fri, 2 Jul 2021 02:21:33 -0400 Subject: [PATCH 1/3] chore: upgrade to Jest 27 --- package.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/package.json b/package.json index 7d3f3cb..5cdde38 100644 --- a/package.json +++ b/package.json @@ -62,7 +62,7 @@ "graphql-tag": "^2.11.0", "isomorphic-unfetch": "^3.0.0", "jest-serializer-vue": "^2.0.2", - "kcd-scripts": "^7.0.3", + "kcd-scripts": "^11.1.0", "lodash.merge": "^4.6.2", "msw": "^0.26.2", "portal-vue": "^2.1.7", From 628ad4c26ba4d932883ff5282a5cc84140b7b972 Mon Sep 17 00:00:00 2001 From: Nick McCurdy Date: Mon, 5 Jul 2021 14:29:59 -0400 Subject: [PATCH 2/3] fix: ESLint config --- .eslintrc.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.eslintrc.js b/.eslintrc.js index 5106ca9..fc368d5 100644 --- a/.eslintrc.js +++ b/.eslintrc.js @@ -5,7 +5,7 @@ module.exports = { extends: [ './node_modules/kcd-scripts/eslint.js', 'plugin:vue/recommended', - 'prettier/vue', + 'prettier', ], plugins: ['vue'], rules: { From e07bee26c097d4c7198fd41f53dd4f3555056260 Mon Sep 17 00:00:00 2001 From: Nick McCurdy Date: Mon, 5 Jul 2021 21:44:43 -0400 Subject: [PATCH 3/3] fix: ESLint config --- .eslintrc.js | 1 + src/__tests__/form-user-event.js | 1 + src/__tests__/render.js | 4 +--- src/__tests__/select-user-event.js | 1 + src/fire-event.js | 1 + 5 files changed, 5 insertions(+), 3 deletions(-) diff --git a/.eslintrc.js b/.eslintrc.js index fc368d5..af8efe8 100644 --- a/.eslintrc.js +++ b/.eslintrc.js @@ -18,5 +18,6 @@ module.exports = { 'testing-library/no-manual-cleanup': 'off', 'testing-library/no-await-sync-events': 'off', 'testing-library/await-fire-event': 'error', + 'testing-library/prefer-user-event': 'off', }, } diff --git a/src/__tests__/form-user-event.js b/src/__tests__/form-user-event.js index f85ce6b..fd46160 100644 --- a/src/__tests__/form-user-event.js +++ b/src/__tests__/form-user-event.js @@ -1,3 +1,4 @@ +/* eslint-enable testing-library/prefer-user-event */ import '@testing-library/jest-dom' import {render, waitFor} from '@testing-library/vue' import userEvent from '@testing-library/user-event' diff --git a/src/__tests__/render.js b/src/__tests__/render.js index ad0f0d8..8f4d2ff 100644 --- a/src/__tests__/render.js +++ b/src/__tests__/render.js @@ -33,9 +33,7 @@ test('renders container', () => { template: '
my content
', }) - expect(container.firstChild).toHaveTextContent( - getByTestId('myDiv').textContent, - ) + expect(container).toHaveTextContent(getByTestId('myDiv').textContent) }) test('container defaults to div', () => { diff --git a/src/__tests__/select-user-event.js b/src/__tests__/select-user-event.js index 5557618..3bc9fe6 100644 --- a/src/__tests__/select-user-event.js +++ b/src/__tests__/select-user-event.js @@ -1,3 +1,4 @@ +/* eslint-enable testing-library/prefer-user-event */ import '@testing-library/jest-dom' import {render} from '@testing-library/vue' import userEvent from '@testing-library/user-event' diff --git a/src/fire-event.js b/src/fire-event.js index 6a87d7a..74c4045 100644 --- a/src/fire-event.js +++ b/src/fire-event.js @@ -15,6 +15,7 @@ Object.keys(dtlFireEvent).forEach(key => { fireEvent[key] = async (...args) => { warnOnChangeOrInputEventCalledDirectly(args[1], key) + // eslint-disable-next-line testing-library/await-fire-event dtlFireEvent[key](...args) await waitFor(() => {}) }