From ce9f541283e80fb388d6048eb44172c13222cba9 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Edgar=20Schn=C3=BCriger?= <github@mediafreak.ch>
Date: Fri, 6 Mar 2020 13:15:36 +0100
Subject: [PATCH 1/4] Alternative approach to preserve mountOptions

I suggest an alternative approach to the problem to preserve things like `props, propsData, updateProps` that are applied to the root node only.
---
 src/__tests__/vuetify.js | 15 +++++----------
 1 file changed, 5 insertions(+), 10 deletions(-)

diff --git a/src/__tests__/vuetify.js b/src/__tests__/vuetify.js
index 9cc8962e..4f647890 100644
--- a/src/__tests__/vuetify.js
+++ b/src/__tests__/vuetify.js
@@ -15,18 +15,13 @@ Vue.use(Vuetify)
 // a <div data-app="true"> node.
 const renderWithVuetify = (component, options, callback) => {
   return render(
-    // anonymous component
+    component,
+    // for Vuetify components that use the $vuetify instance property
     {
-      // Vue's render function
-      render(createElement) {
-        // wrap the component with a <div data-app="true"> node and render the test component
-        return createElement('div', {attrs: {'data-app': true}}, [
-          createElement(component),
-        ])
-      },
+      container: document.createElement('div').setAttribute('data-app', 'true'),
+      vuetify: new Vuetify(),
+      ...options
     },
-    // for Vuetify components that use the $vuetify instance property
-    {vuetify: new Vuetify(), ...options},
     callback,
   )
 }

From 5ec3b996c9404ff4ea383ec0e54513b6b0f00672 Mon Sep 17 00:00:00 2001
From: "edgar.schnueriger" <edgar.schnueriger@geopraevent.ch>
Date: Fri, 6 Mar 2020 13:26:49 +0100
Subject: [PATCH 2/4] Add tests

---
 src/__tests__/components/Vuetify.vue |  7 +++++++
 src/__tests__/vuetify.js             | 12 +++++++++++-
 2 files changed, 18 insertions(+), 1 deletion(-)

diff --git a/src/__tests__/components/Vuetify.vue b/src/__tests__/components/Vuetify.vue
index 3add64fa..b6ec8489 100644
--- a/src/__tests__/components/Vuetify.vue
+++ b/src/__tests__/components/Vuetify.vue
@@ -7,12 +7,19 @@
         <v-card-text>Lorem ipsum dolor sit amet.</v-card-text>
       </v-card>
     </v-dialog>
+    <span v-if="showHint">This is a hint</span>
   </v-app>
 </template>
 
 <script>
 export default {
   name: 'VuetifyDemoComponent',
+  props: {
+    showHint: {
+      type: Boolean,
+      default: false,
+    },
+  },
   data() {
     return {
       show: false,
diff --git a/src/__tests__/vuetify.js b/src/__tests__/vuetify.js
index 4f647890..7627d0ea 100644
--- a/src/__tests__/vuetify.js
+++ b/src/__tests__/vuetify.js
@@ -20,7 +20,7 @@ const renderWithVuetify = (component, options, callback) => {
     {
       container: document.createElement('div').setAttribute('data-app', 'true'),
       vuetify: new Vuetify(),
-      ...options
+      ...options,
     },
     callback,
   )
@@ -39,3 +39,13 @@ test('renders a Vuetify-powered component', async () => {
     </div>
   `)
 })
+
+test('allows changing props', async () => {
+  const {queryByText, updateProps} = renderWithVuetify(VuetifyDemoComponent)
+
+  expect(queryByText('This is a hint')).toBe(null)
+
+  await updateProps({showHint: true})
+
+  expect(queryByText('This is a hint')).not.toBe(null)
+})

From ca320e67a24fcd3a5302de579e11125391808779 Mon Sep 17 00:00:00 2001
From: "edgar.schnueriger" <edgar.schnueriger@geopraevent.ch>
Date: Fri, 6 Mar 2020 13:28:57 +0100
Subject: [PATCH 3/4] Fix comments

---
 src/__tests__/vuetify.js | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/src/__tests__/vuetify.js b/src/__tests__/vuetify.js
index 7627d0ea..32c0577f 100644
--- a/src/__tests__/vuetify.js
+++ b/src/__tests__/vuetify.js
@@ -10,15 +10,15 @@ import VuetifyDemoComponent from './components/Vuetify'
 //            https://vuetifyjs.com/en/getting-started/unit-testing
 Vue.use(Vuetify)
 
-// Custom render wrapper to integrate Vuetify with Vue Testing Library.
+// Custom container to integrate Vuetify with Vue Testing Library.
 // Vuetify requires you to wrap your app with a v-app component that provides
 // a <div data-app="true"> node.
 const renderWithVuetify = (component, options, callback) => {
   return render(
     component,
-    // for Vuetify components that use the $vuetify instance property
     {
       container: document.createElement('div').setAttribute('data-app', 'true'),
+      // for Vuetify components that use the $vuetify instance property
       vuetify: new Vuetify(),
       ...options,
     },

From d36ab03f05844182b5b04f2e34fbd87c3dfe1831 Mon Sep 17 00:00:00 2001
From: "edgar.schnueriger" <edgar.schnueriger@geopraevent.ch>
Date: Fri, 6 Mar 2020 13:49:18 +0100
Subject: [PATCH 4/4] Apply review suggestions

---
 src/__tests__/vuetify.js | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/src/__tests__/vuetify.js b/src/__tests__/vuetify.js
index 32c0577f..972b53bb 100644
--- a/src/__tests__/vuetify.js
+++ b/src/__tests__/vuetify.js
@@ -1,3 +1,4 @@
+import '@testing-library/jest-dom'
 import Vue from 'vue'
 import {render, fireEvent} from '@testing-library/vue'
 import Vuetify from 'vuetify'
@@ -43,9 +44,9 @@ test('renders a Vuetify-powered component', async () => {
 test('allows changing props', async () => {
   const {queryByText, updateProps} = renderWithVuetify(VuetifyDemoComponent)
 
-  expect(queryByText('This is a hint')).toBe(null)
+  expect(queryByText('This is a hint')).not.toBeInTheDocument()
 
   await updateProps({showHint: true})
 
-  expect(queryByText('This is a hint')).not.toBe(null)
+  expect(queryByText('This is a hint')).toBeInTheDocument()
 })