Skip to content

@vue/compiler-sfc peer dependency warning #272

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
edumudu opened this issue Jul 4, 2022 · 3 comments · Fixed by #288
Closed

@vue/compiler-sfc peer dependency warning #272

edumudu opened this issue Jul 4, 2022 · 3 comments · Fixed by #288
Labels
bug Something isn't working released

Comments

@edumudu
Copy link

edumudu commented Jul 4, 2022

Describe the bug
When installing @testing-library/vue in a project with [email protected]+ and no @vue/compiler-sfc a warning of missing @vue/compiler-sfc peer dependencies is shown

To Reproduce Steps to reproduce the behavior:

  • Install the @testing-library/vue in a project with [email protected]+ and no @vue/compiler-sfc

You can view the warning in the terminal on Codesandbox

Expected behavior

Is expected to not show any warning about peer deps

Related information:

  • @testing-library/vue version: 6.6.0
  • Vue version: 3.2.37
  • node version: 16.14.0
  • npm (or yarn) version: [email protected]

Additional context

As of [email protected]+ the package @vue/compiler-sfc is included in the vue and can be accessed as vue/compiler-sfc. So is not needed anymore to install it separately, but currently, this project set it as a peer dependency and doesn't seem to use it directly

More info in the package README

I'm opening this issue to know if I am missing something, if it's alright I would be happy to open a PR if needed

@edumudu edumudu added the bug Something isn't working label Jul 4, 2022
@zhanglolo
Copy link

[email protected]+ also include @vue/compiler-sfc.

@davidysoards
Copy link

+1 OP offered to open a PR, that would be nice.

Copy link

github-actions bot commented Feb 8, 2024

🎉 This issue has been resolved in version 8.0.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working released
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants