Skip to content

Update deps #156

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Sep 28, 2020
Merged

Update deps #156

merged 4 commits into from
Sep 28, 2020

Conversation

afontcu
Copy link
Member

@afontcu afontcu commented Sep 10, 2020

@nickmccurdy just saw that #155 was failing on CI and noticed it was due to eslint rules. So I took a stab at it and fixed the errors – if you still think we should remove package-lock, I'll happily remove it in this PR, or merge this one and then yours should pass.

Oh, and by the way – should this PR trigger a (minor?) release, since types and DTL have been updated?

@afontcu afontcu requested a review from nickserv September 10, 2020 12:48
@codecov
Copy link

codecov bot commented Sep 10, 2020

Codecov Report

Merging #156 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##            master      #156   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            1         1           
  Lines           70        70           
  Branches        13        13           
=========================================
  Hits            70        70           
Impacted Files Coverage Δ
src/vue-testing-library.js 100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 76cdc70...5233a9a. Read the comment docs.

@afontcu afontcu merged commit addae98 into master Sep 28, 2020
@afontcu afontcu deleted the update-deps branch September 28, 2020 10:18
@afontcu
Copy link
Member Author

afontcu commented Sep 28, 2020

🎉 This PR is included in version 5.1.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant