Skip to content

Bump DTL major version #125

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 10 commits into from
Mar 13, 2020
Merged

Bump DTL major version #125

merged 10 commits into from
Mar 13, 2020

Conversation

afontcu
Copy link
Member

@afontcu afontcu commented Mar 12, 2020

No description provided.

@afontcu afontcu added the BREAKING CHANGE This change will require a major version bump label Mar 12, 2020
@afontcu afontcu changed the title Bump major version from DTL Bump DTL major version Mar 12, 2020
@afontcu afontcu mentioned this pull request Mar 12, 2020
Merged
4 tasks
kentcdodds
kentcdodds reviewed Mar 12, 2020
View reviewed changes
src/__tests__/stopwatch.js Outdated
@@ -17,7 +17,7 @@ test('updates component state', async () => {
getByText('Stop')

// Wait for one tick of the event loop.
await wait()
await wait(() => {})
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note that this is probably not how I would test a stopwatch. I would prefer jest.useFakeTimers (in which case you'd need to use act).

Maybe this: https://github.com/kentcdodds/react-testing-library-course/blob/5b1a2d10fa140eae1ea36ec47cc3f52d3edaa90d/src/__tests__/unmounting.js or this: https://github.com/kentcdodds/testing-docs-rtl-examples/blob/cf6b0f3c74287b7b6bca745bc28827c8a2c0c4ee/src/card.test.js can help :)

Thanks!

@codecov
Copy link

codecov bot commented Mar 12, 2020 •
edited
Loading

Codecov Report

Merging #125 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff          @@
##           master   #125   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files           1      1           
  Lines          67     67           
  Branches       13     13           
=====================================
  Hits           67     67
Impacted Files Coverage Δ
src/vue-testing-library.js 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 69261e2...3649eff. Read the comment docs.

@afontcu afontcu marked this pull request as ready for review March 13, 2020 08:28
@afontcu afontcu merged commit c79a388 into master Mar 13, 2020
@afontcu afontcu deleted the bump-dtl-major branch March 13, 2020 08:52
@afontcu
Copy link
Member Author

afontcu commented Mar 13, 2020

🎉 This PR is included in version 5.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kentcdodds kentcdodds kentcdodds left review comments

Assignees
No one assigned
Labels
BREAKING CHANGE This change will require a major version bump released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@afontcu @kentcdodds