Merge branch 'master' into signup

Author: dfcook

tests/__tests__/components/VuexTest.vue renamed to tests/__tests__/components/Store/VuexTest.vue

@@ -0,0 +1,12 @@
+export const store = {
+  state: {
+    count: 0
+  },
+  actions: {
+    increment: ({ commit, state }) => commit('SET_COUNT', state.count + 1),
+    decrement: ({ commit, state }) => commit('SET_COUNT', state.count - 1)
+  },
+  mutations: {
+    SET_COUNT: (state, count) => { state.count = count }
+  }
+}

tests/__tests__/components/Store/store.js

@@ -1,43 +1,50 @@
 import 'jest-dom/extend-expect'
-
-import VuexTest from './components/VuexTest'
 import { cleanup, render, fireEvent } from '@testing-library/vue'
 
+import VuexTest from './components/Store/VuexTest'
+import { store } from './components/Store/store'
+
 afterEach(cleanup)
 
-const store = {
-  state: {
-    count: 0
-  },
-  actions: {
-    increment: ({ commit, state }) => commit('SET_COUNT', state.count + 1),
-    decrement: ({ commit, state }) => commit('SET_COUNT', state.count - 1)
-  },
-  mutations: {
-    SET_COUNT: (state, count) => { state.count = count }
-  }
+// A common testing pattern is to create a custom renderer for a specific test
+// file. This way, common operations such as registering a Vuex store can be
+// abstracted out while avoiding sharing mutable state.
+//
+// Tests should be completely isolated from one another.
+// Read this for additional context: https://kentcdodds.com/blog/test-isolation-with-react
+function renderVuexTestComponent (customStore) {
+  // Render the component and merge the original store and the custom one
+  // provided as a parameter. This way, we can alter some behaviors of the
+  // initial implementation.
+  return render(VuexTest, {
+    store: { ...store, ...customStore }
+  })
 }
 
 test('can render with vuex with defaults', async () => {
-  const { getByTestId, getByText } = render(VuexTest, { store })
+  const { getByTestId, getByText } = renderVuexTestComponent()
   await fireEvent.click(getByText('+'))
 
   expect(getByTestId('count-value')).toHaveTextContent('1')
 })
 
 test('can render with vuex with custom initial state', async () => {
-  store.state.count = 3
-  const { getByTestId, getByText } = render(VuexTest, { store })
+  const { getByTestId, getByText } = renderVuexTestComponent({
+    state: { count: 3 }
+  })
   await fireEvent.click(getByText('-'))
 
   expect(getByTestId('count-value')).toHaveTextContent('2')
 })
 
 test('can render with vuex with custom store', async () => {
-  // this is a silly store that can never be changed
-  jest.spyOn(console, 'error').mockImplementation(() => {})
+  jest.spyOn(console, 'error').mockImplementation(() => { })
 
+  // This is a silly store that can never be changed.
   const store = { state: { count: 1000 } }
+
+  // Notice how here we are not using the helper method, because there's no
+  // need to do that.
   const { getByTestId, getByText } = render(VuexTest, { store })
 
   await fireEvent.click(getByText('+'))