Check the default property of Component for the constructor
#34
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benmonro
approved these changes
Jun 10, 2019
|
@allcontributorsbot please add @pngwn for code, tests |
|
I've put up a pull request to add @pngwn! 🎉 |
|
🎉 This PR is included in version 1.7.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change checks the default property of the
Componentargument inrenderto prevent problems mounting components due to the way that Svelte handles the presence of both named and default imports when compiling tocjs.In order to test this I added another jest transform targetting
.htmlfiles instead of.sveltefiles and used a jest transform that usessvelte.compiledirectly and compiles tocjs. An exampleApp.htmland a test rendering this file was also added.Fixes #32.