Skip to content

Missing direct dependency #21

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
ematipico opened this issue May 18, 2019 · 1 comment · Fixed by #22
Closed

Missing direct dependency #21

ematipico opened this issue May 18, 2019 · 1 comment · Fixed by #22
Labels
released

Comments

@ematipico
Copy link
Contributor

When running the tests I get:

Cannot find module 'dom-testing-library' from 'index.js'

In the README.md it's not written to install this library and I know that other testing libraries like react-testing-library have dom-testing-library as direct dependency. Should it be added?
@ematipico ematipico mentioned this issue May 18, 2019
Merged
@benmonro
Copy link
Member

🎉 This issue has been resolved in version 1.5.6 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: Moved dom-testing-library as direct dependency ematipico/svelte-testing-library
2 participants
@benmonro @ematipico