From 88db98404f83189178615de18830cc22cf69bf77 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Alejandro=20=C3=91=C3=A1=C3=B1ez=20Ortiz?= Date: Tue, 20 Mar 2018 10:01:57 -0500 Subject: [PATCH 1/2] Update axios.js Adding docs about the other HTTP methods. --- src/__mocks__/axios.js | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/src/__mocks__/axios.js b/src/__mocks__/axios.js index 57eb52ec..9d70d624 100644 --- a/src/__mocks__/axios.js +++ b/src/__mocks__/axios.js @@ -1,3 +1,8 @@ module.exports = { get: jest.fn(() => Promise.resolve({data: {}})), } + +// Note: +// For now we don't need any other method (POST/PUT/PATCH), what we have already works fine. +// We will add more methods only if we need to. +// For reference please read: https://github.com/kentcdodds/react-testing-library/issues/2 From 431731bcf39610f128e27e33c43e004207fb246d Mon Sep 17 00:00:00 2001 From: Alejandro Nanez Date: Tue, 20 Mar 2018 10:09:01 -0500 Subject: [PATCH 2/2] adding myself to the contributors list --- .all-contributorsrc | 9 +++++++++ README.md | 6 +++--- 2 files changed, 12 insertions(+), 3 deletions(-) diff --git a/.all-contributorsrc b/.all-contributorsrc index 394eaaeb..4f8ea4f2 100644 --- a/.all-contributorsrc +++ b/.all-contributorsrc @@ -37,6 +37,15 @@ "contributions": [ "code" ] + }, + { + "login": "alejandronanez", + "name": "Alejandro ร‘รกรฑez Ortiz", + "avatar_url": "https://avatars3.githubusercontent.com/u/464978?v=4", + "profile": "http://co.linkedin.com/in/alejandronanez/", + "contributions": [ + "doc" + ] } ] } diff --git a/README.md b/README.md index b6f442bb..ddf70a43 100644 --- a/README.md +++ b/README.md @@ -12,7 +12,7 @@ [![downloads][downloads-badge]][npmtrends] [![MIT License][license-badge]][license] -[![All Contributors](https://img.shields.io/badge/all_contributors-3-orange.svg?style=flat-square)](#contributors) +[![All Contributors](https://img.shields.io/badge/all_contributors-4-orange.svg?style=flat-square)](#contributors) [![PRs Welcome][prs-badge]][prs] [![Code of Conduct][coc-badge]][coc] @@ -354,8 +354,8 @@ Thanks goes to these people ([emoji key][emojis]): -| [
Kent C. Dodds](https://kentcdodds.com)
[๐Ÿ’ป](https://github.com/kentcdodds/react-testing-library/commits?author=kentcdodds "Code") [๐Ÿ“–](https://github.com/kentcdodds/react-testing-library/commits?author=kentcdodds "Documentation") [๐Ÿš‡](#infra-kentcdodds "Infrastructure (Hosting, Build-Tools, etc)") [โš ๏ธ](https://github.com/kentcdodds/react-testing-library/commits?author=kentcdodds "Tests") | [
Ryan Castner](http://audiolion.github.io)
[๐Ÿ“–](https://github.com/kentcdodds/react-testing-library/commits?author=audiolion "Documentation") | [
Daniel Sandiego](https://www.dnlsandiego.com)
[๐Ÿ’ป](https://github.com/kentcdodds/react-testing-library/commits?author=dnlsandiego "Code") | -| :---: | :---: | :---: | +| [
Kent C. Dodds](https://kentcdodds.com)
[๐Ÿ’ป](https://github.com/kentcdodds/react-testing-library/commits?author=kentcdodds "Code") [๐Ÿ“–](https://github.com/kentcdodds/react-testing-library/commits?author=kentcdodds "Documentation") [๐Ÿš‡](#infra-kentcdodds "Infrastructure (Hosting, Build-Tools, etc)") [โš ๏ธ](https://github.com/kentcdodds/react-testing-library/commits?author=kentcdodds "Tests") | [
Ryan Castner](http://audiolion.github.io)
[๐Ÿ“–](https://github.com/kentcdodds/react-testing-library/commits?author=audiolion "Documentation") | [
Daniel Sandiego](https://www.dnlsandiego.com)
[๐Ÿ’ป](https://github.com/kentcdodds/react-testing-library/commits?author=dnlsandiego "Code") | [
Alejandro ร‘รกรฑez Ortiz](http://co.linkedin.com/in/alejandronanez/)
[๐Ÿ“–](https://github.com/kentcdodds/react-testing-library/commits?author=alejandronanez "Documentation") | +| :---: | :---: | :---: | :---: |