chore: fix tests for error suppression to

Author: mpeyper

src/dom/__tests__/errorSuppression.disabled.test.ts

@@ -1,39 +1,14 @@
-import { renderHook } from '..'
-
 describe('error output suppression (disabled) tests', () => {
-  function useError(throwError?: boolean) {
-    if (throwError) {
-      throw new Error('expected')
-    }
-    return true
-  }
-
   const originalConsoleError = console.error
-  const mockConsoleError = jest.fn()
 
   beforeAll(() => {
     process.env.RHTL_DISABLE_ERROR_FILTERING = 'true'
   })
 
-  beforeEach(() => {
-    console.error = mockConsoleError
-  })
-
-  afterEach(() => {
-    console.error = originalConsoleError
-  })
-
-  test('should not suppress error output', () => {
-    const { result } = renderHook(() => useError(true))
-
-    expect(result.error).toEqual(Error('expected'))
-    expect(mockConsoleError).toBeCalledWith(
-      expect.stringMatching(/^Error: Uncaught \[Error: expected\]/),
-      expect.any(Error)
-    )
-    expect(mockConsoleError).toBeCalledWith(
-      expect.stringMatching(/^The above error occurred in the <TestComponent> component:/)
-    )
-    expect(mockConsoleError).toBeCalledTimes(2)
+  test('should not patch console.error', () => {
+    require('..')
+    expect(console.error).toBe(originalConsoleError)
   })
 })
+
+export {}

src/dom/__tests__/errorSuppression.noAfterAll.test.ts

@@ -0,0 +1,24 @@
+describe('error output suppression (noAfterAll) tests', () => {
+  const originalConsoleError = console.error
+
+  beforeAll(() => {
+    // @ts-expect-error Turning off AfterAll -- ignore Jest LifeCycle Type
+    // eslint-disable-next-line no-global-assign
+    afterAll = false
+  })
+
+  describe('first', () => {
+    test('should patch console.error', () => {
+      require('..')
+      expect(console.error).not.toBe(originalConsoleError)
+    })
+  })
+
+  describe('second', () => {
+    test('should still used patched console.error', () => {
+      expect(console.error).not.toBe(originalConsoleError)
+    })
+  })
+})
+
+export {}

src/dom/__tests__/errorSuppression.pure.test.ts

@@ -1,35 +1,10 @@
-import { renderHook } from '../pure'
-
 describe('error output suppression (pure) tests', () => {
-  function useError(throwError?: boolean) {
-    if (throwError) {
-      throw new Error('expected')
-    }
-    return true
-  }
-
   const originalConsoleError = console.error
-  const mockConsoleError = jest.fn()
-
-  beforeEach(() => {
-    console.error = mockConsoleError
-  })
 
-  afterEach(() => {
-    console.error = originalConsoleError
-  })
-
-  test('should not suppress error output', () => {
-    const { result } = renderHook(() => useError(true))
-
-    expect(result.error).toEqual(Error('expected'))
-    expect(mockConsoleError).toBeCalledWith(
-      expect.stringMatching(/^Error: Uncaught \[Error: expected\]/),
-      expect.any(Error)
-    )
-    expect(mockConsoleError).toBeCalledWith(
-      expect.stringMatching(/^The above error occurred in the <TestComponent> component:/)
-    )
-    expect(mockConsoleError).toBeCalledTimes(2)
+  test('should not patch console.error', () => {
+    require('../pure')
+    expect(console.error).toBe(originalConsoleError)
   })
 })
+
+export {}

src/native/__tests__/errorSuppression.disabled.test.ts

@@ -0,0 +1,14 @@
+describe('error output suppression (disabled) tests', () => {
+  const originalConsoleError = console.error
+
+  beforeAll(() => {
+    process.env.RHTL_DISABLE_ERROR_FILTERING = 'true'
+  })
+
+  test('should not patch console.error', () => {
+    require('..')
+    expect(console.error).toBe(originalConsoleError)
+  })
+})
+
+export {}

src/native/__tests__/errorSuppression.noAfterAll.test.ts

@@ -0,0 +1,24 @@
+describe('error output suppression (noAfterAll) tests', () => {
+  const originalConsoleError = console.error
+
+  beforeAll(() => {
+    // @ts-expect-error Turning off AfterAll -- ignore Jest LifeCycle Type
+    // eslint-disable-next-line no-global-assign
+    afterAll = false
+  })
+
+  describe('first', () => {
+    test('should patch console.error', () => {
+      require('..')
+      expect(console.error).not.toBe(originalConsoleError)
+    })
+  })
+
+  describe('second', () => {
+    test('should still used patched console.error', () => {
+      expect(console.error).not.toBe(originalConsoleError)
+    })
+  })
+})
+
+export {}

src/native/__tests__/errorSuppression.pure.test.ts

@@ -0,0 +1,10 @@
+describe('error output suppression (pure) tests', () => {
+  const originalConsoleError = console.error
+
+  test('should not patch console.error', () => {
+    require('../pure')
+    expect(console.error).toBe(originalConsoleError)
+  })
+})
+
+export {}

src/server/__tests__/errorSuppression.disabled.test.ts

@@ -0,0 +1,14 @@
+describe('error output suppression (disabled) tests', () => {
+  const originalConsoleError = console.error
+
+  beforeAll(() => {
+    process.env.RHTL_DISABLE_ERROR_FILTERING = 'true'
+  })
+
+  test('should not patch console.error', () => {
+    require('..')
+    expect(console.error).toBe(originalConsoleError)
+  })
+})
+
+export {}

src/server/__tests__/errorSuppression.noAfterAll.test.ts

@@ -0,0 +1,24 @@
+describe('error output suppression (noAfterAll) tests', () => {
+  const originalConsoleError = console.error
+
+  beforeAll(() => {
+    // @ts-expect-error Turning off AfterAll -- ignore Jest LifeCycle Type
+    // eslint-disable-next-line no-global-assign
+    afterAll = false
+  })
+
+  describe('first', () => {
+    test('should patch console.error', () => {
+      require('..')
+      expect(console.error).not.toBe(originalConsoleError)
+    })
+  })
+
+  describe('second', () => {
+    test('should still used patched console.error', () => {
+      expect(console.error).not.toBe(originalConsoleError)
+    })
+  })
+})
+
+export {}

src/server/__tests__/errorSuppression.pure.test.ts

@@ -0,0 +1,10 @@
+describe('error output suppression (pure) tests', () => {
+  const originalConsoleError = console.error
+
+  test('should not patch console.error', () => {
+    require('../pure')
+    expect(console.error).toBe(originalConsoleError)
+  })
+})
+
+export {}