Skip to content

Commit bab38d9

Browse files
committed
fix: stop appending container elements to document body
1 parent 4f2dd80 commit bab38d9

File tree

3 files changed

+2
-10
lines changed

3 files changed

+2
-10
lines changed

src/dom/pure.ts

-3
Original file line numberDiff line numberDiff line change
@@ -11,12 +11,10 @@ function createDomRenderer<TProps, TResult>(
1111
{ wrapper }: RendererOptions<TProps>
1212
) {
1313
const container = document.createElement('div')
14-
1514
const testHarness = createTestHarness(rendererProps, wrapper)
1615

1716
return {
1817
render(props?: TProps) {
19-
document.body.appendChild(container)
2018
act(() => {
2119
ReactDOM.render(testHarness(props), container)
2220
})
@@ -30,7 +28,6 @@ function createDomRenderer<TProps, TResult>(
3028
act(() => {
3129
ReactDOM.unmountComponentAtNode(container)
3230
})
33-
document.body.removeChild(container)
3431
},
3532
act
3633
}

src/native/pure.ts

-1
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,6 @@ function createNativeRenderer<TProps, TResult>(
1010
{ wrapper }: RendererOptions<TProps>
1111
) {
1212
let container: ReactTestRenderer
13-
1413
const testHarness = createTestHarness(rendererProps, wrapper)
1514

1615
return {

src/server/pure.ts

+2-6
Original file line numberDiff line numberDiff line change
@@ -11,12 +11,10 @@ function createServerRenderer<TProps, TResult>(
1111
rendererProps: RendererProps<TProps, TResult>,
1212
{ wrapper }: RendererOptions<TProps>
1313
) {
14-
const container = document.createElement('div')
15-
16-
const testHarness = createTestHarness(rendererProps, wrapper, false)
17-
1814
let renderProps: TProps | undefined
1915
let hydrated = false
16+
const container = document.createElement('div')
17+
const testHarness = createTestHarness(rendererProps, wrapper, false)
2018

2119
return {
2220
render(props?: TProps) {
@@ -30,7 +28,6 @@ function createServerRenderer<TProps, TResult>(
3028
if (hydrated) {
3129
throw new Error('The component can only be hydrated once')
3230
} else {
33-
document.body.appendChild(container)
3431
act(() => {
3532
ReactDOM.hydrate(testHarness(renderProps), container)
3633
})
@@ -49,7 +46,6 @@ function createServerRenderer<TProps, TResult>(
4946
if (hydrated) {
5047
act(() => {
5148
ReactDOM.unmountComponentAtNode(container)
52-
document.body.removeChild(container)
5349
})
5450
}
5551
},

0 commit comments

Comments
 (0)