We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
wait
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Example: https://runkit.com/aduth/5f5e53aa8ef9ae0013364071
The default value for suppressErrors (true) is only assigned if no options parameter is assigned:
suppressErrors
true
options
preact-hooks-testing-library/src/asyncUtils.ts
Line 44 in 9badbd2
This means if a developer passes options (either an empty object, or with timeout), any errors thrown during wait will not be suppressed.
timeout
Lines 51 to 52 in 9badbd2
@testing-library/react-hooks addresses this by assigning default value during destructuring of the options:
@testing-library/react-hooks
https://github.com/testing-library/react-hooks-testing-library/blob/b16f8bb/src/asyncUtils.js#L41
The text was updated successfully, but these errors were encountered:
Successfully merging a pull request may close this issue.
Example: https://runkit.com/aduth/5f5e53aa8ef9ae0013364071
The default value for
suppressErrors
(true
) is only assigned if nooptions
parameter is assigned:preact-hooks-testing-library/src/asyncUtils.ts
Line 44 in 9badbd2
This means if a developer passes
options
(either an empty object, or withtimeout
), any errors thrown duringwait
will not be suppressed.preact-hooks-testing-library/src/asyncUtils.ts
Lines 51 to 52 in 9badbd2
@testing-library/react-hooks
addresses this by assigning default value during destructuring of the options:https://github.com/testing-library/react-hooks-testing-library/blob/b16f8bb/src/asyncUtils.js#L41
The text was updated successfully, but these errors were encountered: