Skip to content
This repository was archived by the owner on Jul 30, 2020. It is now read-only.

TS error after update TS to version 3.7 #80

Closed
serzmerz opened this issue Nov 13, 2019 · 1 comment
Closed

TS error after update TS to version 3.7 #80

serzmerz opened this issue Nov 13, 2019 · 1 comment

Comments

@serzmerz
Copy link

serzmerz commented Nov 13, 2019

  • native-testing-library version: 5.0.0
  • typescript version: 3.7.2

What you did:

Upgrade ts to version 3.7.2

What happened:

I faced with error:

node_modules/@testing-library/react-native/typings/query-helpers.d.ts:1:10 - error TS2440: Import declaration conflicts with local declaration of 'ReactTestInstance'.

1 import { ReactTestInstance } from 'react-test-renderer';
           ~~~~~~~~~~~~~~~~~


Found 1 error.

It is related to change in TS 3.7:
https://www.typescriptlang.org/docs/handbook/release-notes/typescript-3-7.html#local-and-imported-type-declarations-now-conflict

Problem description:

In ts 3.7 local and imported declarations now conflict, so we need to extend and rename types with the same name.

Suggested solution:

I suggest to rename and extend interfaces in file query-helpers.d.ts
Actually, I found this PR: #79
could you merge it?

Can you help us fix this issue by submitting a pull request?

Yes, but PR is exist #79.

@serzmerz serzmerz reopened this Nov 13, 2019
@bcarroll22
Copy link
Collaborator

bcarroll22 commented Nov 18, 2019

Closing now since this was fixed by the PR you referenced. Thanks!

Closed by #79

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants