From f2f6dcc9e1bc6228a560fdbea8fff0d6f1a9e2a3 Mon Sep 17 00:00:00 2001 From: Jacob Parish Date: Thu, 11 Jun 2020 22:45:02 -0500 Subject: [PATCH 1/3] fix: ensure node exists before using in isArrowFunctionExpression --- lib/node-utils.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/node-utils.ts b/lib/node-utils.ts index b8d3efc4..53e788b8 100644 --- a/lib/node-utils.ts +++ b/lib/node-utils.ts @@ -104,5 +104,5 @@ export function hasThenProperty(node: TSESTree.Node) { } export function isArrowFunctionExpression(node: TSESTree.Node): node is TSESTree.ArrowFunctionExpression { - return node.type === 'ArrowFunctionExpression' + return node && node.type === 'ArrowFunctionExpression' } \ No newline at end of file From 28898d150346885b7e9c68f4279313247be3abb8 Mon Sep 17 00:00:00 2001 From: Jacob Parish Date: Fri, 12 Jun 2020 09:09:01 -0500 Subject: [PATCH 2/3] test: added test case showing empty waitFor --- tests/lib/rules/prefer-find-by.test.ts | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/tests/lib/rules/prefer-find-by.test.ts b/tests/lib/rules/prefer-find-by.test.ts index dd0cf477..e12d86c9 100644 --- a/tests/lib/rules/prefer-find-by.test.ts +++ b/tests/lib/rules/prefer-find-by.test.ts @@ -51,7 +51,10 @@ ruleTester.run(RULE_NAME, rule, { code: ` await waitFor(() => expect(${queryMethod}('baz')).toBeInTheDocument()); ` - })) + })), + { + code: `await waitFor()` + } ], invalid: [ // using reduce + concat 'cause flatMap is not available in node10.x From 2261f2b31ee4b894204b5efa518738af2e4230e4 Mon Sep 17 00:00:00 2001 From: Jacob Parish Date: Fri, 12 Jun 2020 09:12:03 -0500 Subject: [PATCH 3/3] test: added test for empty `wait` --- tests/lib/rules/prefer-find-by.test.ts | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/tests/lib/rules/prefer-find-by.test.ts b/tests/lib/rules/prefer-find-by.test.ts index e12d86c9..7a483c59 100644 --- a/tests/lib/rules/prefer-find-by.test.ts +++ b/tests/lib/rules/prefer-find-by.test.ts @@ -53,7 +53,10 @@ ruleTester.run(RULE_NAME, rule, { ` })), { - code: `await waitFor()` + code: ` + await waitFor(); + await wait(); + ` } ], invalid: [