Allow exceptions for "no-node-access"

[alexey-kozlenkov]

What rule do you want to change?

no-node-access

Does this change cause the rule to produce more or fewer warnings?

Fewer warnings

How will the change be implemented?

render method returns container which has content rendered inside it (div element by default - docs )

The easiest way to access content itself is by using firstChild property
This is hardly avoidable in some cases, such as:

• snapshot testing
• testing if rendering simply has/has not happened
• counting child elements

The rule could ignore firstChild(only?) in some cases.

Example code

const MyComponent = () => <div>Any kind of stuff</div>

describe('some test', () => {
  it('test case', () => {
    const { container } = render(<MyComponent />)

    expect(container.firstChild).toMatchSnapshot()
  })
})

How does the current rule affect the code?

Currently rule highlights container.firstChild part as a mistaken direct Node access

How will the new rule affect the code?

Won't highlight it

Anything else?

No response

Do you want to submit a pull request to change the rule?

No

[Belco90]

Thanks for reporting @alexey-kozlenkov!

I was tempted to suggest an option like allowedProperties where you could specify all the properties needed, but that could be use as an escape hatch. So my proposal is to add a new allowContainerFirstChild option, which would be a boolean to prevent reporting container.firstChild. What do you think?

What about no-container? Does that rule complain about container.firstChild?

[alexey-kozlenkov]

Sure, that would do the job!

No, no-container does not report these lines

[github-actions]

🎉 This issue has been resolved in version 5.6.0 🎉

The release is available on:

• npm package (@latest dist-tag)
• GitHub release

Your semantic-release bot 📦🚀