Remove prefer-expect-query-by rule from shareable configs

[Belco90]

After checking prefer-expect-query-by rule with different people and getting different feedback about it, this rule is definitely too opinionated to be enabled by default in shareable configs. Also, the motivation of the rule is not really clear, so we need to improve the rule doc to clarify what's the use case and corresponding motivation for it.

[emmenko]

Do you know what the confusion is about? Is the doc not clear enough? The main use case is when asserting that an element is not in the document, in which case it's recommended to use expect(queryBy as mentioned in the docs. The rule then ensures some sort of consistency of always using queryBy with expect.

Anyway, it's fine for me to not have it enabled by default, I'm just curious to know what people find confusing about it.

[Belco90]

I found this chat in spectrum about it: https://spectrum.chat/testing-library/general/prefer-expect-query-by-linting-rule~802a01db-1afd-4ca3-b753-1dfcfcc5d1ca

After that, I discussed with @thomlom about the rule and we agreed it looks too opinionated to be enabled by recommended preset. Then I shared with some coworkers and they found it as a weird rule by default too: the main though was "I completely understand how all recommended rules would help me writing testing library tests but not this one in particular".

About if doc is clear enough or not, examples could be improved and I would leave clear what use cases for this rules are (adding link to jest-dom section in testing library doc would help).

If you have anything else in mind we could improve here, let me know. I'll create a PR soon so we can improve it there too.

[emmenko]

I see, thanks for the clarification. Yeah let's do it like this then.

[Belco90]

I guess that ideally we could have a rule enabled by default that forces you to use queryBy instead of getBy when asserting elements are not present, but I'm not sure how to implement that (checking expect().not.toBeInTheDocument and expect().toBeNull() or something similar? I'm afraid we would have to check tons of combination for different matchers and negations), so I think best think we can do for now is just not enabling it by default and specify which are the use cases.

[Belco90]

Closed by #60

[Belco90]

@emmenko By the way: as discussed with Kent C in twitter, probably this rule should evolve to something that prevents using getBy queries when asserting element is not present or its disappearance instead of preventing just asserting always using getBy. That's complex as there are tons of different cases for that: asserting with .not.toBeInTheDocument(), asserting with .toBeNull(), asserting with .toBe(null), waiting for disappearance with waitForElementToBeRemoved (and maybe some more I can't think about now).

Would be a good addition for future versions.

[emmenko]

Yeah definitely! Let's track this as an issue first.

[Belco90]

I'm creating an issue so we can discuss further details there.