feat: Add an option to remove the matching of findBy queries by the prefer-explicit-assert rule #452
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
julienw
commented
Aug 16, 2021
…refer-explicit-assert rule A recent patch implemented matching findBy* queries by the prefer-explicit-assert rule. This patch makes it possible to disable it in cases where it's too distracting. Fixes testing-library#449
julienw
force-pushed
the
449-add-option-to-explicit-assert
branch
from
f985c17 to
1b1a661
Compare
julienw
commented
Aug 16, 2021
julienw
commented
Aug 16, 2021
julienw
commented
Aug 16, 2021
|
I believe this is ready for review now. Also I guess somebody needs to approve the test workflows :-) |
|
The step for publishing the new package version failed, I'm checking why. |
|
🎉 This PR is included in version 4.11.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
|
@all-contributors please add @julienw for bug, code, test |
|
I've put up a pull request to add @julienw! 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A recent patch implemented matching
findBy*queries by theprefer-explicit-assertrule. This patch makes it possible to disable itin cases where it's too distracting.
Checks
Changes
This adds an option so that a user can globally disable that findBy queries are checked by the role.
Context
Fixes #449