Skip to content

No errors or warnings when use render wrapper #246

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
sshmyg opened this issue Oct 30, 2020 · 3 comments
Closed

No errors or warnings when use render wrapper #246

sshmyg opened this issue Oct 30, 2020 · 3 comments
Labels
bug Something isn't working
Milestone

Comments

@sshmyg
Copy link

sshmyg commented Oct 30, 2020

Hello, if I use wrapper for render, eslint not shows any warnings (errors).

With wrapper
image

Without wrapper
image

@Belco90 Belco90 added the bug Something isn't working label Oct 30, 2020
@Belco90
Copy link
Member

Belco90 commented Oct 30, 2020

Hi @sshmyg. Indeed, current version of the plugin is not detecting render wrappers properly, causing false negatives or opted-out rules.

However, this is been addressed properly on v4, which we are working at the moment. To handle this case properly we need to refactor and improve how the plugin works internally, and that's what we are doing in that next major version.

If you want to keep up to date with v4 I suggest you to check issue with all info for v4 and issue for internal refactor + new settings which will solve your mentioned issue.

Apologies for any problem this may have caused.

@sshmyg
Copy link
Author

sshmyg commented Oct 30, 2020

@Belco90 Thank you for the quick replay. 🤝
Will wait for v4.

@Belco90
Copy link
Member

Belco90 commented Apr 11, 2021

This should be fixed on v4.0.0

The release is available on:

@Belco90 Belco90 closed this as completed Apr 11, 2021
@MichaelDeBoey MichaelDeBoey added this to the v4 milestone Apr 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants