-
Notifications
You must be signed in to change notification settings - Fork 148
fix: ensure node exists before using in isArrowFunctionExpression #161
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: ensure node exists before using in isArrowFunctionExpression #161
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello Jacob! Thanks for reporting this bug and creating proper fix 💯
I see this is failing for prefer-find-by
from your screenshot. Could you add an additional test within that rule with empty wait
please?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - approving but if you add the test scenario that'd be great.
For sure! I had the test locally but wasn't sure if it was desired since not entirely related 😄 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tests are more than welcome, specially in a plugin for a testing library :)
@all-contributors please add @jrparish for bug, code and test |
I've put up a pull request to add @jrparish! 🎉 |
🎉 This PR is included in version 3.2.3 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This fixes an issue where the linter blows up when there are no arguments in
wait()
orwaitFor()