Skip to content

fix: ensure node exists before using in isArrowFunctionExpression #161

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 12, 2020

Conversation

jrparish
Copy link
Contributor

This fixes an issue where the linter blows up when there are no arguments in wait() or waitFor()

image

timdeschryver
timdeschryver previously approved these changes Jun 12, 2020
Copy link
Member

@Belco90 Belco90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello Jacob! Thanks for reporting this bug and creating proper fix 💯

I see this is failing for prefer-find-by from your screenshot. Could you add an additional test within that rule with empty wait please?

@Belco90 Belco90 added the bug Something isn't working label Jun 12, 2020
gndelia
gndelia previously approved these changes Jun 12, 2020
Copy link
Collaborator

@gndelia gndelia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - approving but if you add the test scenario that'd be great.

@jrparish jrparish dismissed stale reviews from gndelia and timdeschryver via 28898d1 June 12, 2020 14:09
@jrparish
Copy link
Contributor Author

I see this is failing for prefer-find-by from your screenshot. Could you add an additional test within that rule with empty wait please?

For sure! I had the test locally but wasn't sure if it was desired since not entirely related 😄

Copy link
Member

@Belco90 Belco90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests are more than welcome, specially in a plugin for a testing library :)

@Belco90 Belco90 merged commit 6b8f627 into testing-library:master Jun 12, 2020
@Belco90
Copy link
Member

Belco90 commented Jun 12, 2020

@all-contributors please add @jrparish for bug, code and test

@allcontributors
Copy link
Contributor

@Belco90

I've put up a pull request to add @jrparish! 🎉

@Belco90
Copy link
Member

Belco90 commented Jun 12, 2020

🎉 This PR is included in version 3.2.3 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants