Skip to content

prefer-wait-for rule autofix is modifying Cypress wait() functions #151

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
Miguelerja opened this issue Jun 9, 2020 · 3 comments · Fixed by #152
Closed

prefer-wait-for rule autofix is modifying Cypress wait() functions #151

Miguelerja opened this issue Jun 9, 2020 · 3 comments · Fixed by #152
Labels
bug Something isn't working released

Comments

@Miguelerja
Copy link

Hello,

I have tried to add the rule 'prefer-wait-for' to my code but an unexpected interaction is provoked with my Cypress files. The autofix from the rule is also changing the calls to cy.Wait() for cy.WaitFor() in my Cypress test files

Screenshot 2020-06-09 at 14 04 13
@Miguelerja Miguelerja changed the title prefer-wait-for rule autofix is changing Cypress wait() functions prefer-wait-for rule autofix is modifying Cypress wait() functions Jun 9, 2020
@Belco90 Belco90 added the bug Something isn't working label Jun 9, 2020
@Belco90
Copy link
Member

Belco90 commented Jun 9, 2020

Hi Miguel! Indeed this is a bug, the rule shouldn't apply to anything but testing library utils.

@timdeschryver
Copy link
Member

Let me try to see if I can fix this, seems fair as I've introduced this bug 😅

@timdeschryver timdeschryver mentioned this issue Jun 9, 2020
Merged
@Belco90
Copy link
Member

Belco90 commented Jun 10, 2020

🎉 This issue has been resolved in version 3.2.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working released
Projects
None yet
Milestone
No milestone
3 participants
@Belco90 @timdeschryver @Miguelerja