fix(prefer-screen-queries): take container into account #150
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Belco90
requested changes
Jun 6, 2020
gndelia
reviewed
Jun 7, 2020
| @@ -4,9 +4,11 @@ import { ALL_QUERIES_COMBINATIONS } from '../../../lib/utils'; | |||
|
|
|||
| const ruleTester = createRuleTester(); | |||
|
|
|||
| const ALL_QUERIES_COMBINATIONS_PLUS_CONTAINER = [...ALL_QUERIES_COMBINATIONS, 'container'] | |||
There was a problem hiding this comment.
I think that it would be better to keep ALL_QUERIES_COMBINATIONS and then use container for its specific scenarios. As this would test as valid scenarios that do not match real tests. For instance, in the line 12 it would translate to
screen.container()which is not RTL valid code. Same below for
within(component).container()
gndelia
reviewed
Jun 7, 2020
|
Thank you for the PR! I added a couple of small comments 😄 |
Co-authored-by: Gonzalo D'Elia <[email protected]>
Belco90
requested changes
Jun 10, 2020
Belco90
approved these changes
Jun 10, 2020
|
🎉 This PR is included in version 3.2.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
|
@all-contributors please add @lourenci for bug, code and test |
|
I've put up a pull request to add @lourenci! 🎉 |
gndelia
added a commit
to gndelia/eslint-plugin-testing-library
that referenced
this pull request
Jun 10, 2020
…ing-library#150)" This reverts commit a783036.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It fixes #149.