-
Notifications
You must be signed in to change notification settings - Fork 150
fix(no-wait-for-side-effects): detect await expressions #1008
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(no-wait-for-side-effects): detect await expressions #1008
Conversation
87f42ea
to
bb3ced4
Compare
no-wait-for-side-effects
doesn't detect await expressionno-wait-for-side-effects
doesn't detect await expressions
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1008 +/- ##
==========================================
+ Coverage 96.27% 96.29% +0.01%
==========================================
Files 46 47 +1
Lines 2472 2483 +11
Branches 1025 1027 +2
==========================================
+ Hits 2380 2391 +11
Misses 92 92 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for addressing this bug!
I see code coverage went down, so Codecov complains. Can you add extra tests for no-wait-for-multiple-assertions
? It's indirectly affected (see more details).
no-wait-for-side-effects
doesn't detect await expressions…property-identifier-node-await-expression
…property-identifier-node-await-expression
there was a redundant On a side note - the CI is so fast, I like it! 🚀 |
I'm glad you like the CI speed! We can do even better, hopefully we can switch to vitest soon. |
🎉 This PR is included in version 7.2.2 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Closes #742