Skip to content

Commit ed0212f

Browse files
committed
refactor(prefer-screen-queries): use new rule creator
1 parent 50727e6 commit ed0212f

File tree

2 files changed

+8
-9
lines changed

2 files changed

+8
-9
lines changed

lib/rules/prefer-screen-queries.ts

+6-9
Original file line numberDiff line numberDiff line change
@@ -1,16 +1,13 @@
1+
import { ASTUtils, TSESTree } from '@typescript-eslint/experimental-utils';
2+
import { ALL_QUERIES_COMBINATIONS } from '../utils';
13
import {
2-
ESLintUtils,
3-
TSESTree,
4-
ASTUtils,
5-
} from '@typescript-eslint/experimental-utils';
6-
import { getDocsUrl, ALL_QUERIES_COMBINATIONS } from '../utils';
7-
import {
4+
isCallExpression,
85
isMemberExpression,
6+
isObjectExpression,
97
isObjectPattern,
10-
isCallExpression,
118
isProperty,
12-
isObjectExpression,
139
} from '../node-utils';
10+
import { createTestingLibraryRule } from '../create-testing-library-rule';
1411

1512
export const RULE_NAME = 'prefer-screen-queries';
1613
export type MessageIds = 'preferScreenQueries';
@@ -35,7 +32,7 @@ function usesContainerOrBaseElement(node: TSESTree.CallExpression) {
3532
);
3633
}
3734

38-
export default ESLintUtils.RuleCreator(getDocsUrl)<Options, MessageIds>({
35+
export default createTestingLibraryRule<Options, MessageIds>({
3936
name: RULE_NAME,
4037
meta: {
4138
type: 'suggestion',

tests/lib/rules/prefer-screen-queries.test.ts

+2
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,8 @@ import { ALL_QUERIES_COMBINATIONS } from '../../../lib/utils';
44

55
const ruleTester = createRuleTester();
66

7+
// TODO: include custom queries in test cases
8+
79
ruleTester.run(RULE_NAME, rule, {
810
valid: [
911
{

0 commit comments

Comments
 (0)