refactor: remove occurrences of findBy

Author: emmenko

docs/rules/prefer-expect-query-by.md

@@ -1,9 +1,9 @@
 # Disallow the use of `expect(getBy*)` (prefer-expect-query-by)
 
-The (DOM) Testing Library support three types of queries: `getBy*`, `findBy*` and `queryBy*`. Using `getBy*` or `findBy*` throws an error in case the element is not found. This is useful when using method like `waitForElement`, which are `async` functions that will wait for the element to be found until a certain timeout, after that the test will fail.
-However, when trying to assert if an element is not in the document, we can't use `getBy*` or `findBy*` as the test will fail immediately. Instead it is recommended to use `queryBy*`, which does not throw and therefore we can assert that e.g. `expect(queryByText("Foo")).not.toBeInTheDocument()`.
+The (DOM) Testing Library support three types of queries: `getBy*` and `queryBy*`. Using `getBy*` throws an error in case the element is not found. This is useful when using method like `waitForElement`, which are `async` functions that will wait for the element to be found until a certain timeout, after that the test will fail.
+However, when trying to assert if an element is not in the document, we can't use `getBy*` as the test will fail immediately. Instead it is recommended to use `queryBy*`, which does not throw and therefore we can assert that e.g. `expect(queryByText("Foo")).not.toBeInTheDocument()`.
 
-> The same applies for the `getAll*`, `findAll*` and `queryAll*` queries.
+> The same applies for the `getAll*` and `queryAll*` queries.
 
 ## Rule details
 

lib/rules/prefer-expect-query-by.js

@@ -16,12 +16,7 @@ function isMemberExpression(node) {
 }
 
 function isUsingWrongQueries(node) {
-  return (
-    node.name.startsWith('getBy') ||
-    node.name.startsWith('getAllBy') ||
-    node.name.startsWith('findBy') ||
-    node.name.startsWith('findAllBy')
-  );
+  return node.name.startsWith('getBy') || node.name.startsWith('getAllBy');
 }
 
 function isNotNullOrUndefined(input) {
@@ -94,10 +89,7 @@ module.exports = {
           fix(fixer) {
             return fixer.replaceText(
               nodesGetBy[0],
-              nodesGetBy[0].name.replace(
-                /^((get|find)(All)?(.*))$/,
-                'query$3$4'
-              )
+              nodesGetBy[0].name.replace(/^(get(All)?(.*))$/, 'query$2$3')
             );
           },
         });

tests/lib/rules/prefer-expect-query-by.js

@@ -64,25 +64,5 @@ ruleTester.run('prefer-expect-query-by', rule, {
       errors: [{ messageId: 'expectQueryBy' }],
       output: "expect(rendered.queryAllByText('Hello')).toBeInTheDocument()",
     },
-    {
-      code: "expect(findByText('Hello')).toBeInTheDocument()",
-      errors: [{ messageId: 'expectQueryBy' }],
-      output: "expect(queryByText('Hello')).toBeInTheDocument()",
-    },
-    {
-      code: "expect(rendered.findByText('Hello')).toBeInTheDocument()",
-      errors: [{ messageId: 'expectQueryBy' }],
-      output: "expect(rendered.queryByText('Hello')).toBeInTheDocument()",
-    },
-    {
-      code: "expect(findAllByText('Hello')).toBeInTheDocument()",
-      errors: [{ messageId: 'expectQueryBy' }],
-      output: "expect(queryAllByText('Hello')).toBeInTheDocument()",
-    },
-    {
-      code: "expect(rendered.findAllByText('Hello')).toBeInTheDocument()",
-      errors: [{ messageId: 'expectQueryBy' }],
-      output: "expect(rendered.queryAllByText('Hello')).toBeInTheDocument()",
-    },
   ],
 });