Skip to content

Commit cb8c50c

Browse files
committed
refactor(no-await-sync-query): use custom rule creator
1 parent 5ce0ba0 commit cb8c50c

File tree

2 files changed

+5
-3
lines changed

2 files changed

+5
-3
lines changed

lib/rules/no-await-sync-query.ts

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,13 +1,13 @@
1-
import { ESLintUtils, TSESTree } from '@typescript-eslint/experimental-utils';
2-
import { getDocsUrl } from '../utils';
1+
import { TSESTree } from '@typescript-eslint/experimental-utils';
2+
import { createTestingLibraryRule } from '../create-testing-library-rule';
33

44
export const RULE_NAME = 'no-await-sync-query';
55
export type MessageIds = 'noAwaitSyncQuery';
66
type Options = [];
77

88
const SYNC_QUERIES_REGEXP = /^(get|query)(All)?By(LabelText|PlaceholderText|Text|AltText|Title|DisplayValue|Role|TestId)$/;
99

10-
export default ESLintUtils.RuleCreator(getDocsUrl)<Options, MessageIds>({
10+
export default createTestingLibraryRule<Options, MessageIds>({
1111
name: RULE_NAME,
1212
meta: {
1313
type: 'problem',

tests/lib/rules/no-await-sync-query.test.ts

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -8,6 +8,7 @@ import {
88
const ruleTester = createRuleTester();
99

1010
ruleTester.run(RULE_NAME, rule, {
11+
// TODO: add variants for custom queries for each map
1112
valid: [
1213
// sync queries without await are valid
1314
...SYNC_QUERIES_COMBINATIONS.map((query) => ({
@@ -34,6 +35,7 @@ ruleTester.run(RULE_NAME, rule, {
3435
})),
3536
],
3637

38+
// TODO: add variants for custom queries for each map
3739
invalid: [
3840
// sync queries with await operator are not valid
3941
...SYNC_QUERIES_COMBINATIONS.map((query) => ({

0 commit comments

Comments
 (0)