refactor: review feedback

Author: timdeschryver

lib/configs/angular.ts

@@ -11,7 +11,6 @@ export = {
     'testing-library/no-container': 'error',
     'testing-library/no-debugging-utils': 'error',
     'testing-library/no-dom-import': ['error', 'angular'],
-    'testing-library/no-global-regexp-flag-in-query': 'error',
     'testing-library/no-node-access': 'error',
     'testing-library/no-promise-in-fire-event': 'error',
     'testing-library/no-render-in-setup': 'error',

lib/configs/dom.ts

@@ -8,7 +8,6 @@ export = {
     'testing-library/await-async-query': 'error',
     'testing-library/await-async-utils': 'error',
     'testing-library/no-await-sync-query': 'error',
-    'testing-library/no-global-regexp-flag-in-query': 'error',
     'testing-library/no-promise-in-fire-event': 'error',
     'testing-library/no-wait-for-empty-callback': 'error',
     'testing-library/no-wait-for-multiple-assertions': 'error',

lib/configs/react.ts

@@ -11,7 +11,6 @@ export = {
     'testing-library/no-container': 'error',
     'testing-library/no-debugging-utils': 'error',
     'testing-library/no-dom-import': ['error', 'react'],
-    'testing-library/no-global-regexp-flag-in-query': 'error',
     'testing-library/no-node-access': 'error',
     'testing-library/no-promise-in-fire-event': 'error',
     'testing-library/no-render-in-setup': 'error',

lib/configs/vue.ts

@@ -12,7 +12,6 @@ export = {
     'testing-library/no-container': 'error',
     'testing-library/no-debugging-utils': 'error',
     'testing-library/no-dom-import': ['error', 'vue'],
-    'testing-library/no-global-regexp-flag-in-query': 'error',
     'testing-library/no-node-access': 'error',
     'testing-library/no-promise-in-fire-event': 'error',
     'testing-library/no-render-in-setup': 'error',

lib/node-utils/is-node-of-type.ts

@@ -59,4 +59,3 @@ export const isReturnStatement = ASTUtils.isNodeOfType(
 export const isFunctionExpression = ASTUtils.isNodeOfType(
   AST_NODE_TYPES.FunctionExpression
 );
-export const isIdentifier = ASTUtils.isNodeOfType(AST_NODE_TYPES.Identifier);

lib/rules/no-global-regexp-flag-in-query.ts

@@ -1,9 +1,8 @@
-import { TSESTree } from '@typescript-eslint/utils';
+import { ASTUtils, TSESTree } from '@typescript-eslint/utils';
 
 import { createTestingLibraryRule } from '../create-testing-library-rule';
 import {
   isMemberExpression,
-  isIdentifier,
   isCallExpression,
   isProperty,
   isObjectExpression,
@@ -20,10 +19,10 @@ export default createTestingLibraryRule<Options, MessageIds>({
     docs: {
       description: 'Disallow the use of the global RegExp flag (/g) in queries',
       recommendedConfig: {
-        dom: 'error',
-        angular: 'error',
-        react: 'error',
-        vue: 'error',
+        dom: false,
+        angular: false,
+        react: false,
+        vue: false,
       },
     },
     messages: {
@@ -53,15 +52,18 @@ export default createTestingLibraryRule<Options, MessageIds>({
         if (
           isCallExpression(node.parent) &&
           isMemberExpression(node.parent.callee) &&
-          isIdentifier(node.parent.callee.property)
+          ASTUtils.isIdentifier(node.parent.callee.property)
         ) {
           lint(node, node.parent.callee.property);
         }
       },
       [`CallExpression[callee.type=Identifier] > Literal[regex.flags=/g/].arguments`](
         node: TSESTree.Literal
       ) {
-        if (isCallExpression(node.parent) && isIdentifier(node.parent.callee)) {
+        if (
+          isCallExpression(node.parent) &&
+          ASTUtils.isIdentifier(node.parent.callee)
+        ) {
           lint(node, node.parent.callee);
         }
       },
@@ -73,7 +75,7 @@ export default createTestingLibraryRule<Options, MessageIds>({
           isObjectExpression(node.parent.parent) &&
           isCallExpression(node.parent.parent.parent) &&
           isMemberExpression(node.parent.parent.parent.callee) &&
-          isIdentifier(node.parent.parent.parent.callee.property)
+          ASTUtils.isIdentifier(node.parent.parent.parent.callee.property)
         ) {
           lint(node, node.parent.parent.parent.callee.property);
         }

tests/__snapshots__/index.test.ts.snap

@@ -16,7 +16,6 @@ Object {
         "error",
         "angular",
       ],
-      "testing-library/no-global-regexp-flag-in-query": "error",
       "testing-library/no-node-access": "error",
       "testing-library/no-promise-in-fire-event": "error",
       "testing-library/no-render-in-setup": "error",
@@ -39,7 +38,6 @@ Object {
       "testing-library/await-async-query": "error",
       "testing-library/await-async-utils": "error",
       "testing-library/no-await-sync-query": "error",
-      "testing-library/no-global-regexp-flag-in-query": "error",
       "testing-library/no-promise-in-fire-event": "error",
       "testing-library/no-wait-for-empty-callback": "error",
       "testing-library/no-wait-for-multiple-assertions": "error",
@@ -65,7 +63,6 @@ Object {
         "error",
         "react",
       ],
-      "testing-library/no-global-regexp-flag-in-query": "error",
       "testing-library/no-node-access": "error",
       "testing-library/no-promise-in-fire-event": "error",
       "testing-library/no-render-in-setup": "error",
@@ -96,7 +93,6 @@ Object {
         "error",
         "vue",
       ],
-      "testing-library/no-global-regexp-flag-in-query": "error",
       "testing-library/no-node-access": "error",
       "testing-library/no-promise-in-fire-event": "error",
       "testing-library/no-render-in-setup": "error",

tests/lib/rules/no-global-regexp-flag-in-query.test.ts

@@ -37,8 +37,38 @@ ruleTester.run(RULE_NAME, rule, {
         utils.findByRole('button', {name: /hello/i})
     `,
     `
-        const {queryAllByPlaceholderText} = render(<Component/>)
-        queryAllByPlaceholderText(/hello/i)
+      const {queryAllByPlaceholderText} = render(<Component/>)
+      queryAllByPlaceholderText(/hello/i)
+    `,
+    `
+        const text = 'hello';
+        /hello/g.test(text)
+        text.match(/hello/g)
+    `,
+    `
+        const text = somethingElse()
+        /hello/g.test(text)
+        text.match(/hello/g)
+    `,
+    `
+        import somethingElse from 'somethingElse'
+        somethingElse.lookup(/hello/g)
+    `,
+    `
+        import { screen } from '@testing-library/dom'
+        screen.notAQuery(/hello/g)
+    `,
+    `
+        import { screen } from '@testing-library/dom'
+        screen.notAQuery('button', {name: /hello/g})
+    `,
+    `
+        const utils = render(<Component/>)
+        utils.notAQuery('button', {name: /hello/i})
+    `,
+    `
+        const utils = render(<Component/>)
+        utils.notAQuery(/hello/i)
     `,
   ],
   invalid: [
@@ -59,6 +89,8 @@ ruleTester.run(RULE_NAME, rule, {
       errors: [
         {
           messageId: 'noGlobalRegExpFlagInQuery',
+          line: 3,
+          column: 46,
         },
       ],
     },
@@ -69,6 +101,8 @@ ruleTester.run(RULE_NAME, rule, {
       errors: [
         {
           messageId: 'noGlobalRegExpFlagInQuery',
+          line: 3,
+          column: 65,
         },
       ],
     },
@@ -79,6 +113,8 @@ ruleTester.run(RULE_NAME, rule, {
       errors: [
         {
           messageId: 'noGlobalRegExpFlagInQuery',
+          line: 3,
+          column: 47,
         },
       ],
     },
@@ -89,6 +125,8 @@ ruleTester.run(RULE_NAME, rule, {
       errors: [
         {
           messageId: 'noGlobalRegExpFlagInQuery',
+          line: 3,
+          column: 33,
         },
       ],
     },