Skip to content

Commit b289638

Browse files
authored
fix(prefer-explicit-assert): handle valid getBy* without expect (#257)
1 parent e74c215 commit b289638

File tree

2 files changed

+4
-1
lines changed

2 files changed

+4
-1
lines changed

lib/rules/prefer-explicit-assert.ts

+1
Original file line numberDiff line numberDiff line change
@@ -95,6 +95,7 @@ export default ESLintUtils.RuleCreator(getDocsUrl)<Options, MessageIds>({
9595
});
9696
} else if (assertion) {
9797
const expectCallNode = findClosestCallNode(node, 'expect');
98+
if (!expectCallNode) return;
9899

99100
const expectStatement = expectCallNode.parent as TSESTree.MemberExpression;
100101
const property = expectStatement.property as TSESTree.Identifier;

tests/lib/rules/prefer-explicit-assert.test.ts

+3-1
Original file line numberDiff line numberDiff line change
@@ -67,7 +67,9 @@ ruleTester.run(RULE_NAME, rule, {
6767
code: `queryByText("foo")`,
6868
},
6969
{
70-
code: `expect(getByText('foo')).toBeTruthy()`,
70+
code: `expect(getByText('foo')).toBeTruthy()
71+
72+
fireEvent.click(getByText('bar'));`,
7173
options: [
7274
{
7375
assertion: 'toBeTruthy',

0 commit comments

Comments
 (0)