refactor(no-unnecessary-act): simplify checkNoUnnecessaryActFromBlockStatement's shouldBeReported assigning (#427)

MichaelDeBoey · web-flow · commit a1b1aa91e24d · 2021-07-21T12:21:26.000+02:00
diff --git a/lib/rules/no-unnecessary-act.ts b/lib/rules/no-unnecessary-act.ts
@@ -144,9 +144,7 @@ export default createTestingLibraryRule<Options, MessageIds>({
       }
 
       const shouldBeReported = isStrict
-        ? (hasSomeNonTestingLibraryCall(blockStatementNode.body) &&
-            hasTestingLibraryCall(blockStatementNode.body)) ||
-          !hasSomeNonTestingLibraryCall(blockStatementNode.body)
+        ? hasTestingLibraryCall(blockStatementNode.body)
         : !hasSomeNonTestingLibraryCall(blockStatementNode.body);
 
       if (shouldBeReported) {

Original file line number	Diff line number	Diff line change
`@@ -144,9 +144,7 @@ export default createTestingLibraryRule<Options, MessageIds>({`
`144`	`144`	`}`
`145`	`145`
`146`	`146`	`const shouldBeReported = isStrict`
`147`		`- ? (hasSomeNonTestingLibraryCall(blockStatementNode.body) &&`
`148`		`- hasTestingLibraryCall(blockStatementNode.body)) \|\|`
`149`		`- !hasSomeNonTestingLibraryCall(blockStatementNode.body)`
	`147`	`+ ? hasTestingLibraryCall(blockStatementNode.body)`
`150`	`148`	`: !hasSomeNonTestingLibraryCall(blockStatementNode.body);`
`151`	`149`
`152`	`150`	`if (shouldBeReported) {`