Merge remote-tracking branch 'testing-library/main' into fix/742-get-property-identifier-node-await-expression

Author: StyleShit

.github/ISSUE_TEMPLATE/bug_report.yml

@@ -1,6 +1,7 @@
 name: Bug Report
 description: File a bug report
 labels: ['bug', 'triage']
+type: bug
 body:
   - type: dropdown
     id: read_troubleshooting
@@ -40,24 +41,6 @@ body:
     validations:
       required: true
 
-  - type: input
-    id: npm_yarn_version
-    attributes:
-      label: package manager and version
-      description: Tell us package manager you are using, and what version.
-      placeholder: npm 6.14.13
-    validations:
-      required: true
-
-  - type: input
-    id: operating_system
-    attributes:
-      label: Operating system
-      description: Tell us what operating system you use, and what version.
-      placeholder: macOS Big Sur, version 11.4
-    validations:
-      required: true
-
   - type: textarea
     id: bug_description
     attributes:

.github/ISSUE_TEMPLATE/propose_new_rule.yml

@@ -1,6 +1,7 @@
 name: Propose a new rule
 description: Propose a new rule for the eslint-plugin-testing-library.
 labels: ['new rule', 'triage']
+type: feature
 body:
   - type: input
     id: name_for_new_rule

.github/ISSUE_TEMPLATE/request_general_change.yml

@@ -1,6 +1,7 @@
 name: Request a general change
 description: Request a general change for the eslint-plugin-testing-library.
 labels: ['enhancement', 'triage']
+type: task
 body:
   - type: input
     id: plugin_version

.github/ISSUE_TEMPLATE/request_rule_change.yml

@@ -1,6 +1,7 @@
 name: Request a rule change
 description: Request a rule change for the eslint-plugin-testing-library.
 labels: ['enhancement', 'triage']
+type: feature
 body:
   - type: input
     id: what_rule_do_you_want_to_change

lib/node-utils/index.ts

@@ -278,6 +278,10 @@ function getRootExpression(
 			return parent.expressions[parent.expressions.length - 1] === expression
 				? getRootExpression(parent)
 				: expression;
+
+		case AST_NODE_TYPES.ChainExpression:
+			return getRootExpression(parent);
+
 		default:
 			return expression;
 	}

tests/lib/rules/await-async-queries.test.ts

@@ -93,6 +93,21 @@ ruleTester.run(RULE_NAME, rule, {
 		// async screen queries declaration are valid
 		...createTestCase((query) => `await screen.${query}('foo')`),
 
+		// async queries with optional chaining are valid
+		...createTestCase((query) => `await screen?.${query}('foo')`),
+
+		...createTestCase(
+			(query) => `
+			it('test case', async () => {
+				let renderResult: RenderResult | undefined;
+
+				renderResult = render(<div>text</div>);
+
+				expect(await renderResult?.${query}('text')).toBeDefined();
+			});
+			`
+		),
+
 		// async @marko/testing-library screen queries declaration are valid
 		...createTestCase((query) => `await screen.${query}('foo')`, {
 			testingFramework: '@marko/testing-library',