Skip to content

Commit 8f2e0a5

Browse files
committed
chore: revert node 10.22.1 as minimum version
Minimum node version required for using the plugin is still 10.12 but it was up to 10.22.1 because of a dev dependency. This won't affect usages of the plugin so I'm reverting it. More details here: #234
1 parent b5b93a4 commit 8f2e0a5

File tree

3 files changed

+5
-5
lines changed

3 files changed

+5
-5
lines changed

.github/workflows/pipeline.yml

+2-2
Original file line numberDiff line numberDiff line change
@@ -53,8 +53,8 @@ jobs:
5353

5454
strategy:
5555
matrix:
56-
node: [ '10.22.1', '10', '12', '14' ]
57-
eslint: [ '7.5', '7', ]
56+
node: [ 10.12, 10, 12, 14 ]
57+
eslint: [ 7.5, 7 ]
5858

5959
steps:
6060
- name: Cancel Previous Runs

docs/migrating-to-v4-guide.md

+2-2
Original file line numberDiff line numberDiff line change
@@ -26,10 +26,10 @@ One of the most important changes of `eslint-plugin-testing-library` v4 is the n
2626

2727
### Dependencies
2828

29-
- Min Node version required is `10.22.1`
3029
- Min ESLint version required is `7.5`
30+
- Min Node version required didn't change (`10.12`)
3131

32-
Make sure you have Node and ESLint installed satisfying these new required versions.
32+
Please make sure you have Node and ESLint installed satisfying these required versions.
3333

3434
### New errors reported
3535

package.json

+1-1
Original file line numberDiff line numberDiff line change
@@ -70,7 +70,7 @@
7070
"eslint": "^7.5.0"
7171
},
7272
"engines": {
73-
"node": "^10.22.1 || >=12.0.0",
73+
"node": "^10.12.0 || >=12.0.0",
7474
"npm": ">=6"
7575
},
7676
"license": "MIT"

0 commit comments

Comments
 (0)