Skip to content

Commit 8e2cdcc

Browse files
refactor(no-container): remove wrong use case
scenario
1 parent 3943f45 commit 8e2cdcc

File tree

3 files changed

+1
-16
lines changed

3 files changed

+1
-16
lines changed

docs/rules/no-container.md

-4
Original file line numberDiff line numberDiff line change
@@ -20,10 +20,6 @@ const { container: alias } = render(<Example />);
2020
const button = alias.querySelector('.btn-primary');
2121
```
2222

23-
```js
24-
const button = screen.container.querySelector('.btn-primary');
25-
```
26-
2723
```js
2824
const view = render(<Example />);
2925
const button = view.container.querySelector('.btn-primary');

lib/rules/no-container.ts

+1-2
Original file line numberDiff line numberDiff line change
@@ -72,15 +72,14 @@ export default ESLintUtils.RuleCreator(getDocsUrl)({
7272
) {
7373
if (isMemberExpression(innerNode)) {
7474
if (isIdentifier(innerNode.object)) {
75-
const isScreen = innerNode.object.name === 'screen';
7675
const isContainerName = innerNode.object.name === containerName;
7776
const isRenderWrapper =
7877
innerNode.object.name === renderWrapperName;
7978

8079
hasPropertyContainer =
8180
isIdentifier(innerNode.property) &&
8281
innerNode.property.name === 'container' &&
83-
(isScreen || isRenderWrapper);
82+
isRenderWrapper;
8483

8584
if (isContainerName || hasPropertyContainer) {
8685
context.report({

tests/lib/rules/no-container.test.ts

-10
Original file line numberDiff line numberDiff line change
@@ -81,16 +81,6 @@ ruleTester.run(RULE_NAME, rule, {
8181
},
8282
],
8383
},
84-
{
85-
code: `
86-
const button = screen.container.querySelector('.btn-primary')
87-
`,
88-
errors: [
89-
{
90-
messageId: 'noContainer',
91-
},
92-
],
93-
},
9484
{
9585
code: `
9686
const view = render(<Example />)

0 commit comments

Comments
 (0)