Skip to content

Commit 8833864

Browse files
committed
feat(no-wait-for-snapshot): add to all configs by default
BREAKING CHANGE: `no-wait-for-snapshot` is now enabled by default in all configs
1 parent cf78530 commit 8833864

File tree

7 files changed

+13
-5
lines changed

7 files changed

+13
-5
lines changed

README.md

+1-1
Original file line numberDiff line numberDiff line change
@@ -203,7 +203,7 @@ To enable this configuration use the `extends` property in your
203203
| [`testing-library/no-wait-for-empty-callback`](./docs/rules/no-wait-for-empty-callback.md) | Disallow empty callbacks for `waitFor` and `waitForElementToBeRemoved` | | ![dom-badge][] ![angular-badge][] ![react-badge][] ![vue-badge][] |
204204
| [`testing-library/no-wait-for-multiple-assertions`](./docs/rules/no-wait-for-multiple-assertions.md) | Disallow the use of multiple `expect` calls inside `waitFor` | | |
205205
| [`testing-library/no-wait-for-side-effects`](./docs/rules/no-wait-for-side-effects.md) | Disallow the use of side effects in `waitFor` | | |
206-
| [`testing-library/no-wait-for-snapshot`](./docs/rules/no-wait-for-snapshot.md) | Ensures no snapshot is generated inside of a `waitFor` call | | |
206+
| [`testing-library/no-wait-for-snapshot`](./docs/rules/no-wait-for-snapshot.md) | Ensures no snapshot is generated inside of a `waitFor` call | | ![dom-badge][] ![angular-badge][] ![react-badge][] ![vue-badge][] |
207207
| [`testing-library/prefer-explicit-assert`](./docs/rules/prefer-explicit-assert.md) | Suggest using explicit assertions rather than standalone queries | | |
208208
| [`testing-library/prefer-find-by`](./docs/rules/prefer-find-by.md) | Suggest using `find(All)By*` query instead of `waitFor` + `get(All)By*` to wait for elements | 🔧 | ![dom-badge][] ![angular-badge][] ![react-badge][] ![vue-badge][] |
209209
| [`testing-library/prefer-presence-queries`](./docs/rules/prefer-presence-queries.md) | Ensure appropriate `get*`/`query*` queries are used with their respective matchers | | |

lib/configs/angular.ts

+1
Original file line numberDiff line numberDiff line change
@@ -14,6 +14,7 @@ export = {
1414
'testing-library/no-node-access': 'error',
1515
'testing-library/no-promise-in-fire-event': 'error',
1616
'testing-library/no-wait-for-empty-callback': 'error',
17+
'testing-library/no-wait-for-snapshot': 'error',
1718
'testing-library/prefer-find-by': 'error',
1819
'testing-library/prefer-screen-queries': 'error',
1920
'testing-library/render-result-naming-convention': 'error',

lib/configs/dom.ts

+1
Original file line numberDiff line numberDiff line change
@@ -10,6 +10,7 @@ export = {
1010
'testing-library/no-await-sync-query': 'error',
1111
'testing-library/no-promise-in-fire-event': 'error',
1212
'testing-library/no-wait-for-empty-callback': 'error',
13+
'testing-library/no-wait-for-snapshot': 'error',
1314
'testing-library/prefer-find-by': 'error',
1415
'testing-library/prefer-screen-queries': 'error',
1516
},

lib/configs/react.ts

+1
Original file line numberDiff line numberDiff line change
@@ -15,6 +15,7 @@ export = {
1515
'testing-library/no-promise-in-fire-event': 'error',
1616
'testing-library/no-unnecessary-act': ['error', { isStrict: true }],
1717
'testing-library/no-wait-for-empty-callback': 'error',
18+
'testing-library/no-wait-for-snapshot': 'error',
1819
'testing-library/prefer-find-by': 'error',
1920
'testing-library/prefer-screen-queries': 'error',
2021
'testing-library/render-result-naming-convention': 'error',

lib/configs/vue.ts

+1
Original file line numberDiff line numberDiff line change
@@ -15,6 +15,7 @@ export = {
1515
'testing-library/no-node-access': 'error',
1616
'testing-library/no-promise-in-fire-event': 'error',
1717
'testing-library/no-wait-for-empty-callback': 'error',
18+
'testing-library/no-wait-for-snapshot': 'error',
1819
'testing-library/prefer-find-by': 'error',
1920
'testing-library/prefer-screen-queries': 'error',
2021
'testing-library/render-result-naming-convention': 'error',

lib/rules/no-wait-for-snapshot.ts

+4-4
Original file line numberDiff line numberDiff line change
@@ -21,10 +21,10 @@ export default createTestingLibraryRule<Options, MessageIds>({
2121
'Ensures no snapshot is generated inside of a `waitFor` call',
2222
category: 'Best Practices',
2323
recommendedConfig: {
24-
dom: false,
25-
angular: false,
26-
react: false,
27-
vue: false,
24+
dom: 'error',
25+
angular: 'error',
26+
react: 'error',
27+
vue: 'error',
2828
},
2929
},
3030
messages: {

tests/__snapshots__/index.test.ts.snap

+4
Original file line numberDiff line numberDiff line change
@@ -19,6 +19,7 @@ Object {
1919
"testing-library/no-node-access": "error",
2020
"testing-library/no-promise-in-fire-event": "error",
2121
"testing-library/no-wait-for-empty-callback": "error",
22+
"testing-library/no-wait-for-snapshot": "error",
2223
"testing-library/prefer-find-by": "error",
2324
"testing-library/prefer-screen-queries": "error",
2425
"testing-library/render-result-naming-convention": "error",
@@ -34,6 +35,7 @@ Object {
3435
"testing-library/no-await-sync-query": "error",
3536
"testing-library/no-promise-in-fire-event": "error",
3637
"testing-library/no-wait-for-empty-callback": "error",
38+
"testing-library/no-wait-for-snapshot": "error",
3739
"testing-library/prefer-find-by": "error",
3840
"testing-library/prefer-screen-queries": "error",
3941
},
@@ -61,6 +63,7 @@ Object {
6163
},
6264
],
6365
"testing-library/no-wait-for-empty-callback": "error",
66+
"testing-library/no-wait-for-snapshot": "error",
6467
"testing-library/prefer-find-by": "error",
6568
"testing-library/prefer-screen-queries": "error",
6669
"testing-library/render-result-naming-convention": "error",
@@ -84,6 +87,7 @@ Object {
8487
"testing-library/no-node-access": "error",
8588
"testing-library/no-promise-in-fire-event": "error",
8689
"testing-library/no-wait-for-empty-callback": "error",
90+
"testing-library/no-wait-for-snapshot": "error",
8791
"testing-library/prefer-find-by": "error",
8892
"testing-library/prefer-screen-queries": "error",
8993
"testing-library/render-result-naming-convention": "error",

0 commit comments

Comments
 (0)