Skip to content

Commit 74f4f32

Browse files
committed
feat(prefer-query-by-disappearance): add to all configs by default
BREAKING CHANGE: `prefer-query-by-disappearance` is now enabled by default in all configs
1 parent cf78530 commit 74f4f32

File tree

7 files changed

+13
-5
lines changed

7 files changed

+13
-5
lines changed

README.md

+1-1
Original file line numberDiff line numberDiff line change
@@ -207,7 +207,7 @@ To enable this configuration use the `extends` property in your
207207
| [`testing-library/prefer-explicit-assert`](./docs/rules/prefer-explicit-assert.md) | Suggest using explicit assertions rather than standalone queries | | |
208208
| [`testing-library/prefer-find-by`](./docs/rules/prefer-find-by.md) | Suggest using `find(All)By*` query instead of `waitFor` + `get(All)By*` to wait for elements | 🔧 | ![dom-badge][] ![angular-badge][] ![react-badge][] ![vue-badge][] |
209209
| [`testing-library/prefer-presence-queries`](./docs/rules/prefer-presence-queries.md) | Ensure appropriate `get*`/`query*` queries are used with their respective matchers | | |
210-
| [`testing-library/prefer-query-by-disappearance`](./docs/rules/prefer-query-by-disappearance.md) | Suggest using `queryBy*` queries when waiting for disappearance | | |
210+
| [`testing-library/prefer-query-by-disappearance`](./docs/rules/prefer-query-by-disappearance.md) | Suggest using `queryBy*` queries when waiting for disappearance | | ![dom-badge][] ![angular-badge][] ![react-badge][] ![vue-badge][] |
211211
| [`testing-library/prefer-screen-queries`](./docs/rules/prefer-screen-queries.md) | Suggest using `screen` while querying | | ![dom-badge][] ![angular-badge][] ![react-badge][] ![vue-badge][] |
212212
| [`testing-library/prefer-user-event`](./docs/rules/prefer-user-event.md) | Suggest using `userEvent` over `fireEvent` for simulating user interactions | | |
213213
| [`testing-library/prefer-wait-for`](./docs/rules/prefer-wait-for.md) | Use `waitFor` instead of deprecated wait methods | 🔧 | |

lib/configs/angular.ts

+1
Original file line numberDiff line numberDiff line change
@@ -15,6 +15,7 @@ export = {
1515
'testing-library/no-promise-in-fire-event': 'error',
1616
'testing-library/no-wait-for-empty-callback': 'error',
1717
'testing-library/prefer-find-by': 'error',
18+
'testing-library/prefer-query-by-disappearance': 'error',
1819
'testing-library/prefer-screen-queries': 'error',
1920
'testing-library/render-result-naming-convention': 'error',
2021
},

lib/configs/dom.ts

+1
Original file line numberDiff line numberDiff line change
@@ -11,6 +11,7 @@ export = {
1111
'testing-library/no-promise-in-fire-event': 'error',
1212
'testing-library/no-wait-for-empty-callback': 'error',
1313
'testing-library/prefer-find-by': 'error',
14+
'testing-library/prefer-query-by-disappearance': 'error',
1415
'testing-library/prefer-screen-queries': 'error',
1516
},
1617
};

lib/configs/react.ts

+1
Original file line numberDiff line numberDiff line change
@@ -16,6 +16,7 @@ export = {
1616
'testing-library/no-unnecessary-act': ['error', { isStrict: true }],
1717
'testing-library/no-wait-for-empty-callback': 'error',
1818
'testing-library/prefer-find-by': 'error',
19+
'testing-library/prefer-query-by-disappearance': 'error',
1920
'testing-library/prefer-screen-queries': 'error',
2021
'testing-library/render-result-naming-convention': 'error',
2122
},

lib/configs/vue.ts

+1
Original file line numberDiff line numberDiff line change
@@ -16,6 +16,7 @@ export = {
1616
'testing-library/no-promise-in-fire-event': 'error',
1717
'testing-library/no-wait-for-empty-callback': 'error',
1818
'testing-library/prefer-find-by': 'error',
19+
'testing-library/prefer-query-by-disappearance': 'error',
1920
'testing-library/prefer-screen-queries': 'error',
2021
'testing-library/render-result-naming-convention': 'error',
2122
},

lib/rules/prefer-query-by-disappearance.ts

+4-4
Original file line numberDiff line numberDiff line change
@@ -25,10 +25,10 @@ export default createTestingLibraryRule<Options, MessageIds>({
2525
'Suggest using `queryBy*` queries when waiting for disappearance',
2626
category: 'Possible Errors',
2727
recommendedConfig: {
28-
dom: false,
29-
angular: false,
30-
react: false,
31-
vue: false,
28+
dom: 'error',
29+
angular: 'error',
30+
react: 'error',
31+
vue: 'error',
3232
},
3333
},
3434
messages: {

tests/__snapshots__/index.test.ts.snap

+4
Original file line numberDiff line numberDiff line change
@@ -20,6 +20,7 @@ Object {
2020
"testing-library/no-promise-in-fire-event": "error",
2121
"testing-library/no-wait-for-empty-callback": "error",
2222
"testing-library/prefer-find-by": "error",
23+
"testing-library/prefer-query-by-disappearance": "error",
2324
"testing-library/prefer-screen-queries": "error",
2425
"testing-library/render-result-naming-convention": "error",
2526
},
@@ -35,6 +36,7 @@ Object {
3536
"testing-library/no-promise-in-fire-event": "error",
3637
"testing-library/no-wait-for-empty-callback": "error",
3738
"testing-library/prefer-find-by": "error",
39+
"testing-library/prefer-query-by-disappearance": "error",
3840
"testing-library/prefer-screen-queries": "error",
3941
},
4042
},
@@ -62,6 +64,7 @@ Object {
6264
],
6365
"testing-library/no-wait-for-empty-callback": "error",
6466
"testing-library/prefer-find-by": "error",
67+
"testing-library/prefer-query-by-disappearance": "error",
6568
"testing-library/prefer-screen-queries": "error",
6669
"testing-library/render-result-naming-convention": "error",
6770
},
@@ -85,6 +88,7 @@ Object {
8588
"testing-library/no-promise-in-fire-event": "error",
8689
"testing-library/no-wait-for-empty-callback": "error",
8790
"testing-library/prefer-find-by": "error",
91+
"testing-library/prefer-query-by-disappearance": "error",
8892
"testing-library/prefer-screen-queries": "error",
8993
"testing-library/render-result-naming-convention": "error",
9094
},

0 commit comments

Comments
 (0)