Skip to content

Commit 6f92a90

Browse files
Belco90Belco90
committed
refactor: use common rule tester config
1 parent 4ec2a68 commit 6f92a90

10 files changed

+9
-67
lines changed

‎tests/lib/rules/consistent-data-testid.test.ts

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,11 +1,7 @@
11
import { createRuleTester } from '../test-utils';
22
import rule, { RULE_NAME } from '../../../lib/rules/consistent-data-testid';
33

4-
const ruleTester = createRuleTester({
5-
ecmaFeatures: {
6-
jsx: true,
7-
},
8-
});
4+
const ruleTester = createRuleTester();
95

106
ruleTester.run(RULE_NAME, rule, {
117
valid: [

‎tests/lib/rules/no-container.test.ts

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,11 +1,7 @@
11
import { createRuleTester } from '../test-utils';
22
import rule, { RULE_NAME } from '../../../lib/rules/no-container';
33

4-
const ruleTester = createRuleTester({
5-
ecmaFeatures: {
6-
jsx: true,
7-
},
8-
});
4+
const ruleTester = createRuleTester();
95

106
ruleTester.run(RULE_NAME, rule, {
117
valid: [

‎tests/lib/rules/no-debug.test.ts

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,11 +1,7 @@
11
import { createRuleTester } from '../test-utils';
22
import rule, { RULE_NAME } from '../../../lib/rules/no-debug';
33

4-
const ruleTester = createRuleTester({
5-
ecmaFeatures: {
6-
jsx: true,
7-
},
8-
});
4+
const ruleTester = createRuleTester();
95

106
ruleTester.run(RULE_NAME, rule, {
117
valid: [

‎tests/lib/rules/no-multiple-assertions-wait-for.test.ts

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -3,11 +3,7 @@ import rule, {
33
RULE_NAME,
44
} from '../../../lib/rules/no-multiple-assertions-wait-for';
55

6-
const ruleTester = createRuleTester({
7-
ecmaFeatures: {
8-
jsx: true,
9-
},
10-
});
6+
const ruleTester = createRuleTester();
117

128
ruleTester.run(RULE_NAME, rule, {
139
valid: [

‎tests/lib/rules/no-node-access.test.ts

Lines changed: 1 addition & 24 deletions
Original file line numberDiff line numberDiff line change
@@ -1,24 +1,18 @@
11
import { createRuleTester } from '../test-utils';
22
import rule, { RULE_NAME } from '../../../lib/rules/no-node-access';
33

4-
const ruleTester = createRuleTester({
5-
ecmaFeatures: {
6-
jsx: true,
7-
},
8-
});
4+
const ruleTester = createRuleTester();
95

106
ruleTester.run(RULE_NAME, rule, {
117
valid: [
128
{
13-
filename: 'MyComponent.test.js',
149
code: `
1510
import { screen } from '@testing-library/react';
1611
1712
const buttonText = screen.getByText('submit');
1813
`,
1914
},
2015
{
21-
filename: 'MyComponent.test.js',
2216
code: `
2317
import { screen } from '@testing-library/react';
2418
@@ -28,7 +22,6 @@ ruleTester.run(RULE_NAME, rule, {
2822
`,
2923
},
3024
{
31-
filename: 'MyComponent.test.js',
3225
code: `
3326
import { screen } from '@testing-library/react';
3427
@@ -37,7 +30,6 @@ ruleTester.run(RULE_NAME, rule, {
3730
`,
3831
},
3932
{
40-
filename: 'MyComponent.test.js',
4133
code: `
4234
import { screen } from '@testing-library/react';
4335
@@ -47,7 +39,6 @@ ruleTester.run(RULE_NAME, rule, {
4739
`,
4840
},
4941
{
50-
filename: 'MyComponent.test.js',
5142
code: `
5243
import { render, within } from '@testing-library/react';
5344
@@ -57,7 +48,6 @@ ruleTester.run(RULE_NAME, rule, {
5748
`,
5849
},
5950
{
60-
filename: 'MyComponent.test.js',
6151
code: `
6252
const Component = props => {
6353
return <div>{props.children}</div>
@@ -68,7 +58,6 @@ ruleTester.run(RULE_NAME, rule, {
6858
},
6959
},
7060
{
71-
filename: 'MyComponent.test.js',
7261
code: `
7362
// case: importing custom module
7463
const closestButton = document.getElementById('submit-btn').closest('button');
@@ -81,7 +70,6 @@ ruleTester.run(RULE_NAME, rule, {
8170
],
8271
invalid: [
8372
{
84-
filename: 'MyComponent.test.js',
8573
code: `
8674
// case: without importing TL (aggressive reporting)
8775
const closestButton = document.getElementById('submit-btn')
@@ -90,7 +78,6 @@ ruleTester.run(RULE_NAME, rule, {
9078
errors: [{ messageId: 'noNodeAccess', line: 3 }],
9179
},
9280
{
93-
filename: 'MyComponent.test.js',
9481
code: `
9582
import { screen } from '@testing-library/react';
9683
@@ -106,7 +93,6 @@ ruleTester.run(RULE_NAME, rule, {
10693
],
10794
},
10895
{
109-
filename: 'MyComponent.test.js',
11096
code: `
11197
import { screen } from '@testing-library/react';
11298
@@ -119,7 +105,6 @@ ruleTester.run(RULE_NAME, rule, {
119105
],
120106
},
121107
{
122-
filename: 'MyComponent.test.js',
123108
code: `
124109
import { screen } from '@testing-library/react';
125110
@@ -135,7 +120,6 @@ ruleTester.run(RULE_NAME, rule, {
135120
],
136121
},
137122
{
138-
filename: 'MyComponent.test.js',
139123
code: `
140124
import { screen } from '@testing-library/react';
141125
@@ -148,7 +132,6 @@ ruleTester.run(RULE_NAME, rule, {
148132
],
149133
},
150134
{
151-
filename: 'MyComponent.test.js',
152135
code: `
153136
import { render } from '@testing-library/react';
154137
@@ -162,7 +145,6 @@ ruleTester.run(RULE_NAME, rule, {
162145
],
163146
},
164147
{
165-
filename: 'MyComponent.test.js',
166148
code: `
167149
import { screen } from '@testing-library/react';
168150
@@ -187,7 +169,6 @@ ruleTester.run(RULE_NAME, rule, {
187169
],
188170
},
189171
{
190-
filename: 'MyComponent.test.js',
191172
code: `
192173
import { screen } from '@testing-library/react';
193174
@@ -201,7 +182,6 @@ ruleTester.run(RULE_NAME, rule, {
201182
],
202183
},
203184
{
204-
filename: 'MyComponent.test.js',
205185
code: `
206186
import { render } from '@testing-library/react';
207187
@@ -216,7 +196,6 @@ ruleTester.run(RULE_NAME, rule, {
216196
],
217197
},
218198
{
219-
filename: 'MyComponent.test.js',
220199
code: `
221200
import { render } from '@testing-library/react';
222201
@@ -230,7 +209,6 @@ ruleTester.run(RULE_NAME, rule, {
230209
],
231210
},
232211
{
233-
filename: 'MyComponent.test.js',
234212
code: `
235213
import { screen } from '@testing-library/react';
236214
@@ -261,7 +239,6 @@ ruleTester.run(RULE_NAME, rule, {
261239
],
262240
},
263241
{
264-
filename: 'MyComponent.test.js',
265242
code: `
266243
import { screen } from '@testing-library/react';
267244

‎tests/lib/rules/no-render-in-setup.test.ts

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -2,11 +2,7 @@ import { createRuleTester } from '../test-utils';
22
import { TESTING_FRAMEWORK_SETUP_HOOKS } from '../../../lib/utils';
33
import rule, { RULE_NAME } from '../../../lib/rules/no-render-in-setup';
44

5-
const ruleTester = createRuleTester({
6-
ecmaFeatures: {
7-
jsx: true,
8-
},
9-
});
5+
const ruleTester = createRuleTester();
106

117
ruleTester.run(RULE_NAME, rule, {
128
valid: [

‎tests/lib/rules/no-side-effects-wait-for.test.ts

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,11 +1,7 @@
11
import { createRuleTester } from '../test-utils';
22
import rule, { RULE_NAME } from '../../../lib/rules/no-side-effects-wait-for';
33

4-
const ruleTester = createRuleTester({
5-
ecmaFeatures: {
6-
jsx: true,
7-
},
8-
});
4+
const ruleTester = createRuleTester();
95

106
ruleTester.run(RULE_NAME, rule, {
117
valid: [

‎tests/lib/rules/prefer-find-by.test.ts

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -14,11 +14,7 @@ import rule, {
1414
MessageIds,
1515
} from '../../../lib/rules/prefer-find-by';
1616

17-
const ruleTester = createRuleTester({
18-
ecmaFeatures: {
19-
jsx: true,
20-
},
21-
});
17+
const ruleTester = createRuleTester();
2218

2319
function buildFindByMethod(queryMethod: string) {
2420
return `${getFindByQueryVariant(queryMethod)}${queryMethod.split('By')[1]}`;

‎tests/lib/rules/render-result-naming-convention.test.ts

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -3,11 +3,7 @@ import rule, {
33
RULE_NAME,
44
} from '../../../lib/rules/render-result-naming-convention';
55

6-
const ruleTester = createRuleTester({
7-
ecmaFeatures: {
8-
jsx: true,
9-
},
10-
});
6+
const ruleTester = createRuleTester();
117

128
ruleTester.run(RULE_NAME, rule, {
139
valid: [

‎tests/lib/test-utils.ts

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,6 @@
11
import { resolve } from 'path';
22
import { TSESLint } from '@typescript-eslint/experimental-utils';
33

4-
// TODO: remove ecmaFeatures object from other tests files
5-
64
const DEFAULT_TEST_CASE_CONFIG = {
75
filename: 'MyComponent.test.js',
86
};
@@ -42,7 +40,6 @@ export const createRuleTester = (
4240
parserOptions: {
4341
ecmaVersion: 2018,
4442
sourceType: 'module',
45-
// TODO: should we deep merge here?
4643
ecmaFeatures: {
4744
jsx: true,
4845
},

0 commit comments

Comments
 (0)