Skip to content

Commit 69d5bbe

Browse files
authored
refactor: remove mechanism to match files to be reported (#297)
1 parent 461809f commit 69d5bbe

6 files changed

+5
-297
lines changed

lib/detect-testing-library-utils.ts

+1-19
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,6 @@ import {
2727

2828
export type TestingLibrarySettings = {
2929
'testing-library/utils-module'?: string;
30-
'testing-library/filename-pattern'?: string;
3130
'testing-library/custom-renders'?: string[];
3231
};
3332

@@ -56,7 +55,6 @@ type GetCustomModuleImportNodeFn = () => ImportModuleNode | null;
5655
type GetTestingLibraryImportNameFn = () => string | undefined;
5756
type GetCustomModuleImportNameFn = () => string | undefined;
5857
type IsTestingLibraryImportedFn = () => boolean;
59-
type IsValidFilenameFn = () => boolean;
6058
type IsGetQueryVariantFn = (node: TSESTree.Identifier) => boolean;
6159
type IsQueryQueryVariantFn = (node: TSESTree.Identifier) => boolean;
6260
type IsFindQueryVariantFn = (node: TSESTree.Identifier) => boolean;
@@ -90,7 +88,6 @@ export interface DetectionHelpers {
9088
getTestingLibraryImportName: GetTestingLibraryImportNameFn;
9189
getCustomModuleImportName: GetCustomModuleImportNameFn;
9290
isTestingLibraryImported: IsTestingLibraryImportedFn;
93-
isValidFilename: IsValidFilenameFn;
9491
isGetQueryVariant: IsGetQueryVariantFn;
9592
isQueryQueryVariant: IsQueryQueryVariantFn;
9693
isFindQueryVariant: IsFindQueryVariantFn;
@@ -110,8 +107,6 @@ export interface DetectionHelpers {
110107
isNodeComingFromTestingLibrary: IsNodeComingFromTestingLibraryFn;
111108
}
112109

113-
const DEFAULT_FILENAME_PATTERN = '^.*\\.(test|spec)\\.[jt]sx?$';
114-
115110
const FIRE_EVENT_NAME = 'fireEvent';
116111
const RENDER_NAME = 'render';
117112

@@ -132,9 +127,6 @@ export function detectTestingLibraryUtils<
132127

133128
// Init options based on shared ESLint settings
134129
const customModule = context.settings['testing-library/utils-module'];
135-
const filenamePattern =
136-
context.settings['testing-library/filename-pattern'] ??
137-
DEFAULT_FILENAME_PATTERN;
138130
const customRenders = context.settings['testing-library/custom-renders'];
139131

140132
/**
@@ -243,15 +235,6 @@ export function detectTestingLibraryUtils<
243235
);
244236
};
245237

246-
/**
247-
* Determines whether filename is valid or not for current file
248-
* being analyzed based on "testing-library/filename-pattern" setting.
249-
*/
250-
const isValidFilename: IsValidFilenameFn = () => {
251-
const fileName = context.getFilename();
252-
return !!fileName.match(filenamePattern);
253-
};
254-
255238
/**
256239
* Determines whether a given node is `get*` query variant or not.
257240
*/
@@ -536,7 +519,7 @@ export function detectTestingLibraryUtils<
536519
* Determines if file inspected meets all conditions to be reported by rules or not.
537520
*/
538521
const canReportErrors: CanReportErrorsFn = () => {
539-
return isTestingLibraryImported() && isValidFilename();
522+
return isTestingLibraryImported();
540523
};
541524

542525
/**
@@ -566,7 +549,6 @@ export function detectTestingLibraryUtils<
566549
getTestingLibraryImportName,
567550
getCustomModuleImportName,
568551
isTestingLibraryImported,
569-
isValidFilename,
570552
isGetQueryVariant,
571553
isQueryQueryVariant,
572554
isFindQueryVariant,

0 commit comments

Comments
 (0)