Skip to content

Commit 67cf059

Browse files
committed
feat(no-unnecessary-act): add to React config by default
BREAKING CHANGE: `no-unnecessary-act` is now enabled by default in the React config (with `isStrict` set to `true`)
1 parent 3383e9f commit 67cf059

File tree

4 files changed

+9
-2
lines changed

4 files changed

+9
-2
lines changed

README.md

+1-1
Original file line numberDiff line numberDiff line change
@@ -199,7 +199,7 @@ To enable this configuration use the `extends` property in your
199199
| [`testing-library/no-node-access`](./docs/rules/no-node-access.md) | Disallow direct Node access | | ![angular-badge][] ![react-badge][] ![vue-badge][] |
200200
| [`testing-library/no-promise-in-fire-event`](./docs/rules/no-promise-in-fire-event.md) | Disallow the use of promises passed to a `fireEvent` method | | ![dom-badge][] ![angular-badge][] ![react-badge][] ![vue-badge][] |
201201
| [`testing-library/no-render-in-setup`](./docs/rules/no-render-in-setup.md) | Disallow the use of `render` in testing frameworks setup functions | | |
202-
| [`testing-library/no-unnecessary-act`](./docs/rules/no-unnecessary-act.md) | Disallow wrapping Testing Library utils or empty callbacks in `act` | | |
202+
| [`testing-library/no-unnecessary-act`](./docs/rules/no-unnecessary-act.md) | Disallow wrapping Testing Library utils or empty callbacks in `act` | | ![react-badge][] |
203203
| [`testing-library/no-wait-for-empty-callback`](./docs/rules/no-wait-for-empty-callback.md) | Disallow empty callbacks for `waitFor` and `waitForElementToBeRemoved` | | ![dom-badge][] ![angular-badge][] ![react-badge][] ![vue-badge][] |
204204
| [`testing-library/no-wait-for-multiple-assertions`](./docs/rules/no-wait-for-multiple-assertions.md) | Disallow the use of multiple `expect` calls inside `waitFor` | | |
205205
| [`testing-library/no-wait-for-side-effects`](./docs/rules/no-wait-for-side-effects.md) | Disallow the use of side effects in `waitFor` | | |

lib/configs/react.ts

+1
Original file line numberDiff line numberDiff line change
@@ -13,6 +13,7 @@ export = {
1313
'testing-library/no-dom-import': ['error', 'react'],
1414
'testing-library/no-node-access': 'error',
1515
'testing-library/no-promise-in-fire-event': 'error',
16+
'testing-library/no-unnecessary-act': ['error', { isStrict: true }],
1617
'testing-library/no-wait-for-empty-callback': 'error',
1718
'testing-library/prefer-find-by': 'error',
1819
'testing-library/prefer-screen-queries': 'error',

lib/rules/no-unnecessary-act.ts

+1-1
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,7 @@ export default createTestingLibraryRule<Options, MessageIds>({
2727
recommendedConfig: {
2828
dom: false,
2929
angular: false,
30-
react: false,
30+
react: ['error', { isStrict: true }],
3131
vue: false,
3232
},
3333
},

tests/__snapshots__/index.test.ts.snap

+6
Original file line numberDiff line numberDiff line change
@@ -54,6 +54,12 @@ Object {
5454
],
5555
"testing-library/no-node-access": "error",
5656
"testing-library/no-promise-in-fire-event": "error",
57+
"testing-library/no-unnecessary-act": Array [
58+
"error",
59+
Object {
60+
"isStrict": true,
61+
},
62+
],
5763
"testing-library/no-wait-for-empty-callback": "error",
5864
"testing-library/prefer-find-by": "error",
5965
"testing-library/prefer-screen-queries": "error",

0 commit comments

Comments
 (0)