fix(prefer-explicit-assert): avoid raising error on destructuring

Author: afontcu

lib/rules/prefer-explicit-assert.js

@@ -24,6 +24,12 @@ const isDeclared = node => node.parent.type === 'VariableDeclarator';
 const isReturnedByReturnStatement = node =>
   node.parent.type === 'ReturnStatement';
 
+const isInDestructuringStatement = node =>
+  (node.parent.type === 'Property' &&
+    node.parent.parent.type === 'ObjectPattern') ||
+  (node.parent.type === 'ArrayPattern' &&
+    node.parent.parent.type === 'VariableDeclarator');
+
 module.exports = {
   meta: {
     type: 'suggestion',
@@ -63,6 +69,7 @@ module.exports = {
 
         if (
           isValidQuery(node, customQueryNames) &&
+          !isInDestructuringStatement(node) &&
           !isDirectlyCalledByFunction(callExpressionNode) &&
           !isReturnedByArrowFunctionExpression(callExpressionNode) &&
           !isDeclared(callExpressionNode) &&

tests/lib/rules/prefer-explicit-assert.js

@@ -50,6 +50,15 @@ ruleTester.run('prefer-explicit-assert', rule, {
     {
       code: `getByIcon('foo')`, // custom `getBy` query not extended through options
     },
+    {
+      code: `const { getByText } = render()`,
+    },
+    {
+      code: `it('test', () => { const { getByText } = render() })`,
+    },
+    {
+      code: `it('test', () => { const [ getByText ] = render() })`,
+    },
   ],
 
   invalid: [