Skip to content

Commit 5497dc2

Browse files
authored
refactor: fix ts-expect-error (#873)
1 parent 93a6ab9 commit 5497dc2

File tree

2 files changed

+19
-6
lines changed

2 files changed

+19
-6
lines changed

lib/rules/no-await-sync-events.ts

+6-6
Original file line numberDiff line numberDiff line change
@@ -76,8 +76,8 @@ export default createTestingLibraryRule<Options, MessageIds>({
7676
property.id.name === 'delay' &&
7777
isLiteral(property.init) &&
7878
property.init.value &&
79-
// @ts-expect-error -- TODO: fix me
80-
property.init.value > 0
79+
Number.isInteger(property.init.value) &&
80+
Number(property.init.value) > 0
8181
);
8282
},
8383
AssignmentExpression(node: TSESTree.AssignmentExpression) {
@@ -89,8 +89,8 @@ export default createTestingLibraryRule<Options, MessageIds>({
8989
isLiteral(node.right) &&
9090
node.right.value !== null
9191
) {
92-
// @ts-expect-error -- TODO: fix me
93-
hasDelayDeclarationOrAssignmentGTZero = node.right.value > 0;
92+
hasDelayDeclarationOrAssignmentGTZero =
93+
Number.isInteger(node.right.value) && Number(node.right.value) > 0;
9494
}
9595
},
9696
'AwaitExpression > CallExpression'(node: TSESTree.CallExpression) {
@@ -143,8 +143,8 @@ export default createTestingLibraryRule<Options, MessageIds>({
143143
property.key.name === 'delay' &&
144144
isLiteral(property.value) &&
145145
!!property.value.value &&
146-
// @ts-expect-error -- TODO: fix me
147-
property.value.value > 0
146+
Number.isInteger(property.value.value) &&
147+
Number(property.value.value) > 0
148148
);
149149

150150
const simulateEventFunctionName = simulateEventFunctionIdentifier.name;

tests/lib/rules/no-await-sync-events.test.ts

+13
Original file line numberDiff line numberDiff line change
@@ -142,6 +142,12 @@ ruleTester.run(RULE_NAME, rule, {
142142
code: `() => {
143143
await userEvent.type(element, 'bar', {delay: 1234})
144144
}
145+
`,
146+
},
147+
{
148+
code: `() => {
149+
await userEvent.type(element, 'bar', {delay: null})
150+
}
145151
`,
146152
},
147153
{
@@ -155,6 +161,13 @@ ruleTester.run(RULE_NAME, rule, {
155161
const delay = 10
156162
await userEvent.keyboard('foo', {delay})
157163
}
164+
`,
165+
},
166+
{
167+
code: `async() => {
168+
const delay = null
169+
await userEvent.keyboard('foo', {delay})
170+
}
158171
`,
159172
},
160173
{

0 commit comments

Comments
 (0)