Skip to content

Commit 3ccb5fe

Browse files
MichaelDeBoeyMichaelDeBoey
committed
feat: support ESLint 8.x
BREAKING CHANGE: Requires ESLint@^8.0.0-0
1 parent 3383e9f commit 3ccb5fe

29 files changed

+6
-33
lines changed

‎.github/workflows/pipeline.yml

+1-1
Original file line numberDiff line numberDiff line change
@@ -52,7 +52,7 @@ jobs:
5252
strategy:
5353
matrix:
5454
node: [12.22.0, 12, 14.17.0, 14, '16.0', 16]
55-
eslint: [7.5, 7]
55+
eslint: ['^8.0.0-0']
5656

5757
steps:
5858
- name: Cancel Previous Runs

‎lib/rules/await-async-query.ts

-1
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,6 @@ export default createTestingLibraryRule<Options, MessageIds>({
2020
type: 'problem',
2121
docs: {
2222
description: 'Enforce promises from async queries to be handled',
23-
category: 'Best Practices',
2423
recommendedConfig: {
2524
dom: 'error',
2625
angular: 'error',

‎lib/rules/await-async-utils.ts

-1
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,6 @@ export default createTestingLibraryRule<Options, MessageIds>({
1919
type: 'problem',
2020
docs: {
2121
description: 'Enforce promises from async utils to be awaited properly',
22-
category: 'Best Practices',
2322
recommendedConfig: {
2423
dom: 'error',
2524
angular: 'error',

‎lib/rules/await-fire-event.ts

-1
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,6 @@ export default createTestingLibraryRule<Options, MessageIds>({
1919
type: 'problem',
2020
docs: {
2121
description: 'Enforce promises from `fireEvent` methods to be handled',
22-
category: 'Best Practices',
2322
recommendedConfig: {
2423
dom: false,
2524
angular: false,

‎lib/rules/consistent-data-testid.ts

-1
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,6 @@ export default createTestingLibraryRule<Options, MessageIds>({
1818
type: 'suggestion',
1919
docs: {
2020
description: 'Ensures consistent usage of `data-testid`',
21-
category: 'Best Practices',
2221
recommendedConfig: {
2322
dom: false,
2423
angular: false,

‎lib/rules/no-await-sync-events.ts

-1
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,6 @@ export default createTestingLibraryRule<Options, MessageIds>({
2121
type: 'problem',
2222
docs: {
2323
description: 'Disallow unnecessary `await` for sync events',
24-
category: 'Best Practices',
2524
recommendedConfig: {
2625
dom: false,
2726
angular: false,

‎lib/rules/no-await-sync-query.ts

-1
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,6 @@ export default createTestingLibraryRule<Options, MessageIds>({
1313
type: 'problem',
1414
docs: {
1515
description: 'Disallow unnecessary `await` for sync queries',
16-
category: 'Best Practices',
1716
recommendedConfig: {
1817
dom: 'error',
1918
angular: 'error',

‎lib/rules/no-container.ts

-1
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,6 @@ export default createTestingLibraryRule<Options, MessageIds>({
2020
type: 'problem',
2121
docs: {
2222
description: 'Disallow the use of `container` methods',
23-
category: 'Best Practices',
2423
recommendedConfig: {
2524
dom: false,
2625
angular: 'error',

‎lib/rules/no-debug.ts

-1
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,6 @@ export default createTestingLibraryRule<Options, MessageIds>({
3131
type: 'problem',
3232
docs: {
3333
description: 'Disallow the use of debugging utilities like `debug`',
34-
category: 'Best Practices',
3534
recommendedConfig: {
3635
dom: false,
3736
angular: 'error',

‎lib/rules/no-dom-import.ts

-1
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,6 @@ export default createTestingLibraryRule<Options, MessageIds>({
1818
type: 'problem',
1919
docs: {
2020
description: 'Disallow importing from DOM Testing Library',
21-
category: 'Best Practices',
2221
recommendedConfig: {
2322
dom: false,
2423
angular: ['error', 'angular'],

‎lib/rules/no-manual-cleanup.ts

-1
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,6 @@ export default createTestingLibraryRule<Options, MessageIds>({
2929
type: 'problem',
3030
docs: {
3131
description: 'Disallow the use of `cleanup`',
32-
category: 'Best Practices',
3332
recommendedConfig: {
3433
dom: false,
3534
angular: false,

‎lib/rules/no-node-access.ts

-1
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,6 @@ export default createTestingLibraryRule<Options, MessageIds>({
1313
type: 'problem',
1414
docs: {
1515
description: 'Disallow direct Node access',
16-
category: 'Best Practices',
1716
recommendedConfig: {
1817
dom: false,
1918
angular: 'error',

‎lib/rules/no-promise-in-fire-event.ts

-1
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,6 @@ export default createTestingLibraryRule<Options, MessageIds>({
2020
docs: {
2121
description:
2222
'Disallow the use of promises passed to a `fireEvent` method',
23-
category: 'Best Practices',
2423
recommendedConfig: {
2524
dom: 'error',
2625
angular: 'error',

‎lib/rules/no-render-in-setup.ts

-1
Original file line numberDiff line numberDiff line change
@@ -50,7 +50,6 @@ export default createTestingLibraryRule<Options, MessageIds>({
5050
docs: {
5151
description:
5252
'Disallow the use of `render` in testing frameworks setup functions',
53-
category: 'Best Practices',
5453
recommendedConfig: {
5554
dom: false,
5655
angular: false,

‎lib/rules/no-unnecessary-act.ts

-1
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,6 @@ export default createTestingLibraryRule<Options, MessageIds>({
2323
docs: {
2424
description:
2525
'Disallow wrapping Testing Library utils or empty callbacks in `act`',
26-
category: 'Possible Errors',
2726
recommendedConfig: {
2827
dom: false,
2928
angular: false,

‎lib/rules/no-wait-for-empty-callback.ts

-1
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,6 @@ export default createTestingLibraryRule<Options, MessageIds>({
1818
docs: {
1919
description:
2020
'Disallow empty callbacks for `waitFor` and `waitForElementToBeRemoved`',
21-
category: 'Best Practices',
2221
recommendedConfig: {
2322
dom: 'error',
2423
angular: 'error',

‎lib/rules/no-wait-for-multiple-assertions.ts

-1
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,6 @@ export default createTestingLibraryRule<Options, MessageIds>({
1717
docs: {
1818
description:
1919
'Disallow the use of multiple `expect` calls inside `waitFor`',
20-
category: 'Best Practices',
2120
recommendedConfig: {
2221
dom: false,
2322
angular: false,

‎lib/rules/no-wait-for-side-effects.ts

-1
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,6 @@ export default createTestingLibraryRule<Options, MessageIds>({
2020
type: 'suggestion',
2121
docs: {
2222
description: 'Disallow the use of side effects in `waitFor`',
23-
category: 'Best Practices',
2423
recommendedConfig: {
2524
dom: false,
2625
angular: false,

‎lib/rules/no-wait-for-snapshot.ts

-1
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,6 @@ export default createTestingLibraryRule<Options, MessageIds>({
1919
docs: {
2020
description:
2121
'Ensures no snapshot is generated inside of a `waitFor` call',
22-
category: 'Best Practices',
2322
recommendedConfig: {
2423
dom: false,
2524
angular: false,

‎lib/rules/prefer-explicit-assert.ts

-1
Original file line numberDiff line numberDiff line change
@@ -69,7 +69,6 @@ export default createTestingLibraryRule<Options, MessageIds>({
6969
docs: {
7070
description:
7171
'Suggest using explicit assertions rather than standalone queries',
72-
category: 'Best Practices',
7372
recommendedConfig: {
7473
dom: false,
7574
angular: false,

‎lib/rules/prefer-find-by.ts

-1
Original file line numberDiff line numberDiff line change
@@ -56,7 +56,6 @@ export default createTestingLibraryRule<Options, MessageIds>({
5656
docs: {
5757
description:
5858
'Suggest using `find(All)By*` query instead of `waitFor` + `get(All)By*` to wait for elements',
59-
category: 'Best Practices',
6059
recommendedConfig: {
6160
dom: 'error',
6261
angular: 'error',

‎lib/rules/prefer-presence-queries.ts

-1
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,6 @@ export default createTestingLibraryRule<Options, MessageIds>({
1111
name: RULE_NAME,
1212
meta: {
1313
docs: {
14-
category: 'Best Practices',
1514
description:
1615
'Ensure appropriate `get*`/`query*` queries are used with their respective matchers',
1716
recommendedConfig: {

‎lib/rules/prefer-query-by-disappearance.ts

-1
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,6 @@ export default createTestingLibraryRule<Options, MessageIds>({
2323
docs: {
2424
description:
2525
'Suggest using `queryBy*` queries when waiting for disappearance',
26-
category: 'Possible Errors',
2726
recommendedConfig: {
2827
dom: false,
2928
angular: false,

‎lib/rules/prefer-screen-queries.ts

-1
Original file line numberDiff line numberDiff line change
@@ -40,7 +40,6 @@ export default createTestingLibraryRule<Options, MessageIds>({
4040
type: 'suggestion',
4141
docs: {
4242
description: 'Suggest using `screen` while querying',
43-
category: 'Best Practices',
4443
recommendedConfig: {
4544
dom: 'error',
4645
angular: 'error',

‎lib/rules/prefer-user-event.ts

-1
Original file line numberDiff line numberDiff line change
@@ -71,7 +71,6 @@ export default createTestingLibraryRule<Options, MessageIds>({
7171
docs: {
7272
description:
7373
'Suggest using `userEvent` over `fireEvent` for simulating user interactions',
74-
category: 'Best Practices',
7574
recommendedConfig: {
7675
dom: false,
7776
angular: false,

‎lib/rules/prefer-wait-for.ts

-1
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,6 @@ export default createTestingLibraryRule<Options, MessageIds>({
2626
type: 'suggestion',
2727
docs: {
2828
description: 'Use `waitFor` instead of deprecated wait methods',
29-
category: 'Best Practices',
3029
recommendedConfig: {
3130
dom: false,
3231
angular: false,

‎lib/rules/render-result-naming-convention.ts

-1
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,6 @@ export default createTestingLibraryRule<Options, MessageIds>({
2424
type: 'suggestion',
2525
docs: {
2626
description: 'Enforce a valid naming for return value from `render`',
27-
category: 'Best Practices',
2827
recommendedConfig: {
2928
dom: false,
3029
angular: 'error',

‎package.json

+5-5
Original file line numberDiff line numberDiff line change
@@ -42,17 +42,17 @@
4242
"prepare": "is-ci || husky install"
4343
},
4444
"dependencies": {
45-
"@typescript-eslint/experimental-utils": "^4.30.0"
45+
"@typescript-eslint/experimental-utils": "^5.0.0-0"
4646
},
4747
"devDependencies": {
4848
"@commitlint/cli": "^13.1.0",
4949
"@commitlint/config-conventional": "^13.1.0",
5050
"@types/jest": "^27.0.1",
5151
"@types/node": "^12.20.23",
52-
"@typescript-eslint/eslint-plugin": "^4.30.0",
53-
"@typescript-eslint/parser": "^4.30.0",
52+
"@typescript-eslint/eslint-plugin": "^5.0.0-0",
53+
"@typescript-eslint/parser": "^5.0.0-0",
5454
"cpy-cli": "^3.1.1",
55-
"eslint": "^7.32.0",
55+
"eslint": "^8.0.0-0",
5656
"eslint-config-kentcdodds": "^19.1.1",
5757
"eslint-config-prettier": "^8.3.0",
5858
"eslint-plugin-import": "^2.24.2",
@@ -72,7 +72,7 @@
7272
"typescript": "^4.4.2"
7373
},
7474
"peerDependencies": {
75-
"eslint": "^7.5.0"
75+
"eslint": "^8.0.0-0"
7676
},
7777
"engines": {
7878
"node": "^12.22.0 || ^14.17.0 || >=16.0.0",

‎tests/fake-rule.ts

-1
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,6 @@ export default createTestingLibraryRule<Options, MessageIds>({
2626
type: 'problem',
2727
docs: {
2828
description: 'Fake rule to test rule maker and detection helpers',
29-
category: 'Possible Errors',
3029
recommendedConfig: {
3130
dom: false,
3231
angular: false,

0 commit comments

Comments
 (0)